preserve white spaces on Web #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
alex-mechler
suggested changes
Apr 13, 2023
alex-mechler
left a comment
alex-mechler
left a comment
There was a problem hiding this comment.
Can you have the changes in the fork be the same as the ones proposed upstream? That way when we update the fork to a newer upstream, we do not reintroduce the same bug as Picker will be expecting the preserveSpacesInLabel prop
|
@alex-mechler we can't apply the same changes since they're not same library. |
alex-mechler
approved these changes
Apr 13, 2023
alex-mechler
left a comment
alex-mechler
left a comment
There was a problem hiding this comment.
Ah yes, thanks for pointing that out @0xmiroslav. Hadn't had my coffee yet this morning 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a temporary solution to keeping whitespaces in Picker on Web (Expensify/App#16329) , and the changes added here should be reverted once the PR from
@react-native-picker/pickeris merged: react-native-picker/picker#485.