Allow displaying an SVG logo using svg source #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
in the current version of this library only image assets (like
.png
etc) can be used as a logo within QR code, svg assets would not work.What this does
This PR tries to make it possible to use svgs.
I have not found any reasonable way to do this via the single
logo
prop, as there is no React component that could accept eitherImageSourcePropType
or an SVG and handle every case correctly. Some conditional logic is required to handle the svg prop, thats why I decided to add it as a new prop, while the oldlogo
prop will work unchanged.logoSVG
prop that accepts an svg and will render itlogoColor
prop to set thefill
property of the logo"<svg ....>"
@svgr/webpack
- its a very popular lib)Image
fromreact-native-svg
react-native-svg
which handle all the casesI consider this WIP and api might still change
examples
ios
web
android