Add example App #206
Merged
Add example App #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kicu
force-pushed
the
kicu/add-example-app
branch
from
6deab26 to
66ed7dc
Compare
|
@luacmartins this is the PR that introduces Example app, it's mostly commits moved from our old fork, with some small tweaks so it works and builds correctly. CC @grgia @awesomejerry (I have no idea if you're still contributing to this or not - feel free to comment if you do) |
WoLewicki
reviewed
Aug 23, 2024
| "@svgr/webpack": "^8.1.0", | ||
| "file-loader": "^6.2.0", | ||
| "react": "18.2.0", | ||
| "react-native": "^0.73.6", |
There was a problem hiding this comment.
Would be nice to bump the version to newest RN in some follow-ups. But then macos would probably stop working so idk.
Kicu
force-pushed
the
kicu/add-example-app
branch
from
d2e5e37 to
1dc3fea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an example app to help developers who want to work locally on
react-native-qrcode-svg.All of the important code is kept within
Exampledirectory. This PR is expected to introduce no changes to the library or api, it just adds useful developer toolingrec-qrcode.mov
Details
yarnbecause when I usednpmthe locallink:...dependency doesn't work; I have not found a better way to link to local library that wouldn't break alsoSupported platforms:
Important files: