Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Odd adapter parsing #2

Closed
GoogleCodeExporter opened this Issue Aug 3, 2015 · 10 comments

Comments

Projects
None yet
1 participant
What steps will reproduce the problem?
1. Use GATCGGAAGAGCGGTTCAGCAGGAATGCCGAGATCGGAAG as adapter1
2. Use GATCGGAAGAGCTCGTCAGCAGGAATGCCGAGATCGGAAG as adapter2
3. Issue fastq-mcf -n <adapter>.fa <fastq>

What is the expected output? What do you see instead?
Should show that there are two adapters as input.  You will see that it read 
the first adapter and discarded the second adapter.

What version of the product are you using? On what operating system?
ea-utils.1.0.3-145.tar.gz on Fedora 14 / 2.6.35.13-92.fc14.x86_64

Please provide any additional information below.


Original issue reported on code.google.com by rdirect...@gmail.com on 16 Jun 2011 at 4:02

Adapter input is "fasta" format.... so

>name
ad1
>name
ad2

Original comment by earone...@gmail.com on 20 Jun 2011 at 6:38

Original comment by earone...@gmail.com on 20 Jun 2011 at 8:37

  • Added labels: Priority-Low, Type-Other
  • Removed labels: Priority-Medium, Type-Defect

Original comment by earone...@gmail.com on 20 Jun 2011 at 8:38

  • Changed state: Invalid
  • Added labels: Priority-Medium, Type-Defect
  • Removed labels: Priority-Low, Type-Other
Also, it only reports the adapters found.   So if you pass 20 of them, it will 
only report the 3 or 4 it finds.

Original comment by earone...@gmail.com on 21 Jun 2011 at 1:57

[deleted comment]
In my opinion this issue should be re-open as "valid" and addressed.  One of 
the adapter in my example is actually a real illumina adapter and fastq-mcf had 
failed to recognize it.  The abitrariness of your "filtering" is worrisome.

Original comment by rdirect...@gmail.com on 21 Jun 2011 at 3:23

If you can give me an example of where an adapter should be clipped, that would 
be OK.   I believe the adapter was "real"... it's filtered  if it's not found 
in the fastq file in significant numbers.

Original comment by earone...@gmail.com on 11 Jan 2012 at 5:39

[deleted comment]
I'm going to close this issue, only because it's old, and I can't reproduce it 
reliably.  I did greatly increase the sampling window to fix a number of issues 
people have seen where they were concerned with undetected adapters, however at 
some point, the benefits outweigh the risks of false-positive clipping.

Original comment by mooncost...@gmail.com on 10 May 2012 at 4:04

Original comment by earone...@gmail.com on 31 May 2012 at 1:41

  • Changed state: WontFix

@ExpressionAnalysis ExpressionAnalysis pushed a commit that referenced this issue Jun 20, 2017

@wandai330 wandai330 Merge pull request #2 from wandai330/int-type-overflow
Some int type variable overflow
14d6c8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment