Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Two patches for OSX portability #56
Conversation
ExpressionAnalysis
merged commit e556e16
into
ExpressionAnalysis:master
May 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
wltrimbl commentedApr 6, 2017
One option is to replace apple's gzip
https://www.drupal.org/node/1901508
this PR removes the
--rsyncableoption from gzip for portability.getline.cthat fails to allocate memory for the null terminator when the line length is a multiple of 64. After porting to OSX, one of the tests failed with corrupt fastq when successive calls to read_line overwrote and corrupted data already in the fq structure. This was an off-by-one error in the test to see if getstr should allocate more memory.