Display full timestamp on revisions table Date column

[swierczek]

Suggest an idea for ExpressionEngine

Is your feature request related to a problem? Please describe.
The revisions table Date column doesn't display seconds, but it's fairly common to display the full timestamp in atitle attribute so it displays on hover in case the user wants the full data. We have instances where revisions are saved either in the same minute or after another, and it's beneficial to see the full time with seconds.

Describe the solution you'd like
Wrap the Date field in <span title="(full_timestamp)"> so the full value is available on hover:

Describe alternatives you've considered
Alternatively, instead of outputting the Date value with seconds removed, the Date column could just output the full value via ee()->localize->human_time($entry->edit_date->format('U'), true, true)

Teachability, Documentation, Adoption, Migration Strategy
If the span option is implemented, it wouldn't be immediately apparent that this functionality exists, but it's fairly common behavior around the web related to dates and times. If the full timestamp is used (human_time(x, x, true)), then no additional teachability/documentation would be needed.

• I am capable and would like to work on implementation of this feature if it is considered.

[swierczek]

Patch file for this potential change:

diff --git a/system/ee/ExpressionEngine/Controller/Publish/AbstractPublish.php b/system/ee/ExpressionEngine/Controller/Publish/AbstractPublish.php
index 2b7fe019d..1c6d1f7ac 100644
--- a/system/ee/ExpressionEngine/Controller/Publish/AbstractPublish.php
+++ b/system/ee/ExpressionEngine/Controller/Publish/AbstractPublish.php
@@ -147,7 +147,9 @@ abstract class AbstractPublish extends CP_Controller
         $table->setColumns(
             array(
                 'rev_id',
-                'rev_date',
+                'rev_date' => array(
+                    'encode' => false
+                ),
                 'rev_author',
                 'manage' => array(
                     'encode' => false
@@ -189,7 +191,7 @@ abstract class AbstractPublish extends CP_Controller
                 'attrs' => $attrs,
                 'columns' => array(
                     $i,
-                    ee()->localize->human_time($version->version_date->format('U')),
+                    '<span title="'.ee()->localize->human_time($version->version_date->format('U'), true, true).'">' . ee()->localize->human_time($version->version_date->format('U')) . '</span>',
                     $authors[$version->author_id],
                     $toolbar
                 )
@@ -206,6 +208,9 @@ abstract class AbstractPublish extends CP_Controller
             $edit_date = ($entry->edit_date)
                 ? ee()->localize->human_time($entry->edit_date->format('U'))
                 : null;
+            $edit_date_full = ($entry->edit_date)
+                ? ee()->localize->human_time($entry->edit_date->format('U'), true, true)
+                : null;
 
             array_unshift(
                 $data,
@@ -213,7 +218,7 @@ abstract class AbstractPublish extends CP_Controller
                     'attrs' => $attrs,
                     'columns' => array(
                         $current_id,
-                        $edit_date,
+                        '<span title="' . $edit_date_full . '">' . $edit_date . '</span>',
                         $current_author_id,
                         '<span class="st-open">' . lang('current') . '</span>'
                     ))
@@ -269,12 +274,15 @@ abstract class AbstractPublish extends CP_Controller
             $edit_date = ($entry->edit_date)
                 ? ee()->localize->human_time($entry->edit_date->format('U'))
                 : null;
+            $edit_date_full = ($entry->edit_date)
+                ? ee()->localize->human_time($entry->edit_date->format('U'), true, true)
+                : null;
 
             $data[] = array(
                 'attrs' => $attrs,
                 'columns' => array(
                     $i,
-                    $edit_date,
+                    '<span title="' . $edit_date_full . '">' . $edit_date . '</span>',
                     $authors[$entry->author_id],
                     '<a href="' . ee('CP/URL')->make('publish/edit/entry/' . $entry->entry_id, $urlParams) . '"><span class="st-open">' . lang('current') . '</span></a>'
                 )

[swierczek]

Alternative patch file to display the full timestamp instead of the <span> route:

diff --git a/system/ee/ExpressionEngine/Controller/Publish/AbstractPublish.php b/system/ee/ExpressionEngine/Controller/Publish/AbstractPublish.php
index 2b7fe019d..a2f813039 100644
--- a/system/ee/ExpressionEngine/Controller/Publish/AbstractPublish.php
+++ b/system/ee/ExpressionEngine/Controller/Publish/AbstractPublish.php
@@ -189,7 +189,7 @@ abstract class AbstractPublish extends CP_Controller
                 'attrs' => $attrs,
                 'columns' => array(
                     $i,
-                    ee()->localize->human_time($version->version_date->format('U')),
+                    ee()->localize->human_time($version->version_date->format('U'), true, true),
                     $authors[$version->author_id],
                     $toolbar
                 )
@@ -204,7 +204,7 @@ abstract class AbstractPublish extends CP_Controller
 
             // Current
             $edit_date = ($entry->edit_date)
-                ? ee()->localize->human_time($entry->edit_date->format('U'))
+                ? ee()->localize->human_time($entry->edit_date->format('U'), true, true)
                 : null;
 
             array_unshift(
@@ -267,7 +267,7 @@ abstract class AbstractPublish extends CP_Controller
 
             // Current
             $edit_date = ($entry->edit_date)
-                ? ee()->localize->human_time($entry->edit_date->format('U'))
+                ? ee()->localize->human_time($entry->edit_date->format('U'), true, true)
                 : null;
 
             $data[] = array(

[swierczek]

Line ~314 would also need to be updated to ee()->localize->human_time($autosave->edit_date, true, true). I missed this in both of my patch files.

[intoeetive]

@swierczek would you mind opening actual pull request with this change? I think the solution without extra span is cleaner - and this is good addition overall

[swierczek]

PRs created for both EE 6 (#3650) and EE 7 (#3648)

[intoeetive]

Thank you! Looks like you need to sign CLA in on of those PRs as first-time contributor

[swierczek]

Done!