Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilities: Search and Replace escaping slashes #118

Closed
silenz88 opened this Issue Feb 6, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@silenz88
Copy link

silenz88 commented Feb 6, 2019

Description of the problem

Utilities: Search and Replace seems to have some issues at least with templates. I hadn't have the time to figure everything out yet. Oftentimes it didn't actually replace anything when I used it although I got a success message.

One reproduceable issue is this:

How To Reproduce
Steps to reproduce the behavior:

Today I did a search and replace on all templates trying to replace
{exp:channel:entries
with
{exp:channel:entries site="mysite"
in all templates and ended up with
{exp:channel:entries site=\"mysite\"

Trying another replace to get rid of the backslashes does not work.

To make things worse when I search for site="mysite" in the Template Manager, I do not get any results. So I have to look in any single template to clean up the mess and need to remember which one I fixed already.

Environment Details:

  • Version: 5.1.3
  • PHP Version 7.2.14
  • MySQL Version MySQL 5.5.60-0

@kevincupp kevincupp changed the title Utilities: Search and Replace broken Utilities: Search and Replace escaping slashes Feb 13, 2019

@kevincupp

This comment has been minimized.

Copy link
Contributor

kevincupp commented Feb 28, 2019

Sorry for your trouble! Search and Replace was working fine in general, so I changed the title of this issue. Looks like we were unnecessarily escaping quotes for replacements in templates only, I'll push up a fix for that.

@kevincupp kevincupp closed this in 25194a8 Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.