Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when creating a template group with suggested valid characters #166

Closed
mindpixel-labs opened this Issue Mar 26, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@mindpixel-labs
Copy link

mindpixel-labs commented Mar 26, 2019

Description of the problem
An observation I made in the Template Manager when creating groups. It says you can have a period within a template group but I get an error when it goes to create it. For example: .my-template-group

While it doesn't make sense to create a template group that would be hidden, it may be best to still validate the user input and let them know not to do that.

How To Reproduce
Steps to reproduce the behavior:

  1. Create a template group called .my-template-group
  2. Hit save and you will be redirected to an error message that says Error: The Template Group _my-template-group does not exist.
  3. If you go back to the Template Manager, it does show the template as created with the correct name, but if go to click it you will get the same error.

Error Messages

Error: The Template Group _my-template-group does not exist.


Screenshots / Videos / Template Code
Example 1:
Just an example here where I triggered an error explicitly to see the available valid characters within a template group.
image

Environment Details:

  • Version: 5.2.1
  • PHP Version 7.2
  • MySQL Version 5.6
  • OS: macOS High Sierra 10.13.6
  • Web Server: Apache

Possible Solution
The error message/suggested valid characters should exclude the dot for template groups.

Let me know if you need any more details!

@kevincupp

This comment has been minimized.

Copy link
Contributor

kevincupp commented Mar 28, 2019

This is actually a quirk in how PHP handles variable names in $_GET:

http://ca.php.net/variables.external#language.variables.external.dot-in-names

We'll have to work around it. Thanks for the report!

@kevincupp kevincupp closed this in 2badbb4 Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.