[EE5/6] Search module should use results parameter when pagination isn't applied

[PaulBaileyAtChan]

When results aren't paginated, the search module is hard-coded to return at most 100 hits (see below), and the results parameter is ignored.

There's no good reason for this. In cases where pagination isn't being applied, it would make sense to use the existing results parameter as a maximum. A hard-coded default if the results parameter isn't present would make sense, but the results parameter should override this — whether larger or smaller than the default.

[PaulBaileyAtChan]

To add a bit of flesh here: my own use-case is that I'm taking search results from simple search, and post-processing to present them in a more user-friendly way. Because of how I'm doing this, I have no need for pagination. But if I don't use pagination, the maximum number of results I can have is fixed in the code at 100. So my only option to increase this limit is to hack the EE code — which I'd rather not do, for obvious reasons.

My tentative suggestion is:

This picks up the limit from the results parameter, even if pagination isn't being used. I believe this is robust, because $pagination->per_page is given a sensible default if the results parameter isn't present.

This might be an obscure use-case, but I can't see any obvious issues with the proposed change. Providing access to the results limit using the results parameter, rather than fixing the limit in code, just makes sense.