-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS templates are synchronized only when visiting CP -> Templates #2063
Comments
@bytebaby Looking at the sample folder structure you provided, it does not look right to me. It should be something like I would also double check your If you can confirm that, |
The direcotory "en" is a simple template group folder like "Products" or "Services". The index.html and style.css for the start page are in the "de" directory, which has always worked without problems over the years. :) The $config['save_tmpl_files'] = 'y' option was missing in config.php; But isn't it remarkable? As soon as I log into the backend and ONLY click on the "Templates" menu item, the change is transferred to the browser when the website is called up |
Ok, so can you confirm I understand you correctly:
|
It is exactly like that. |
I gonna take a look on that. I didn't known templates 2 levels down on groups are supported. |
Please, @bytebaby , help me here. Does the structure of the directories of templates looks like this?
Is |
Thank you! One more thing. What do you mean by this?
How this new arrangement looks like, please? |
With pleasure.
I hope I could help :) |
Sooooooo... |
Yes, it worked like this for 9 years. |
Summarizing, the file is loaded and served, but using the link without the main group doesn't trigger the update from the file. @bytebaby , in case the group is named anything else than
(Please, forgive all these questions! I'm trying to narrow down the scope of the tests I need to do.) |
@bytebaby , I did some tests. We are talking about 2 things here:
The firstTesting whether the file
Everything as it should, by the documentation. I think you used an undocumented bug as a feature, which disappeared at some point between versions 6.2.7 and 6.3.2. You can "reenable" it by disabling the Strict URLs setting, what I don't recommend. From the docs:
Can you, please, test opening the CSS files and changing the Strict URL setting? You don't even need to edit your site. Just change the setting and call the same URL you use on the Also, keep in mind that you can't have a group called The secondI couldn't replicate the saving issue on the last version, 6.34, but I'll do more tests. Actually, I've found that the header |
I tried the following. Template group "news" set as default group and converted the style.css to foobar.css. In the source code, the line looks like this (regardless of whether strict URLs are enabled or disabled):
Result: The CSS file is no longer loaded. Only the bare markup is displayed in the browser :) If I convert foobar.css back to style.css, the CSS file is loaded again and appears in the source code:
However, the problem persists even if I disable strict URLs. I'm not sure if I could help. I would like to do that. Thank you for your work! :) The bug also persists with the update to EE 6.3.4 |
So, you're using the (I can't understand the reason it stopped to work just by renaming the file. Hmmmmmnnnn...) |
Sorry, I guess I wasn't fully awake yet :)
One of these lines is contained in (I'm trying it out on the live system of my site segert.net ;) |
I guess I know what happened. Please, look for me in the Slack Channel. Let's move this conversation before all the devs go crazy. |
I misunderstood what happened here. The problem 1 doesn't exist:
I couldn't reproduce the second. I'm sorry. |
Bug found! Working on it! |
@bytebaby , can you, please, give this PR a try? It fixes a bug I found while trying to help you. However, I'm not sure the bug you found is the same I found. |
@robsonsobral – I'm not on Github very often, what does "PR" mean? – |
From Github docs:
You can test right now and I need you to do it! I ask that you, please, backup and replace the file Thank you for your patience and help. |
I'm sorry, but unfortunately it still doesn't work. See the short screencast below: https://download.segert.net/eebug.mp4 I could set up temporary FTP and admin access for you. |
You're using the same version suffix, @bytebaby . After you update the file, is the link generated by the |
@bytebaby , wait for a new testing version soon! |
Done, @bytebaby ! |
Yes. |
Thank you, @bytebaby , for reporting this. While I tried to reproduce this bug, I found some edge cases. The code is now more robust and the tests cover more situations. |
Resolved #2063, where outdated resources could be served
Summary: If I edit the style.css in the template folder ("/templates/default_site/mydirectory/de/style.css") remotely via FTP/SFTP, the changes are no longer transmitted/displayed after a (hard) reload .
When I load the "style.css" file from the template folder with my CSS editor "Nova" and make changes, the browser does not accept these changes. It doesn't matter whether I work on my provider's server or with my local web server (MAMP).
But if I open the CSS file in the EE backend with the template editor (only open it, don't even save it), then I see the changes and suddenly the browser also shows them (this applies to Chrome, Firefox, Safari and the caches I had deactivated, template caching is also deactivated).
Another note: I have upgraded to EE 6.3.2 for two customers and the problem occurs there too.
I changed the style.css via editor for a customer with EE 6.2.7. The changes were immediately visible online in the "page source code" of the browser. After that I updated this website to EE 6.3.2. After that I had the same problem: ExpressionEngine doesn't propagate the CSS changes to the browser. Even if I use a different editor, a different Mac computer or a different IP.
Now I have no choice but to reference the CSS file directly from another directory in the root (so not from "user/templates/etc"). Then everything works as usual again.
PHP 7.4
MySQL 5.7.37
EE 6.3.2 and 6.3.3
Editor: Nova from Panic
The text was updated successfully, but these errors were encountered: