Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments Setting Off, still shows Comments column in Entries Listing #2080

Closed
ic360-com opened this issue May 12, 2022 · 2 comments · Fixed by #2580
Closed

Comments Setting Off, still shows Comments column in Entries Listing #2080

ic360-com opened this issue May 12, 2022 · 2 comments · Fixed by #2580
Labels

Comments

@ic360-com
Copy link

When switching off Comments in the overall CP Settings... I would expect the Comments column in the Entries Listings to disappear.
But maybe keep it as a toggled option to enable historical Comments to be displayed if required.

@robinsowell robinsowell added the enhancement New feature or request label May 12, 2022
@robinsowell
Copy link
Contributor

I'm thinking I wouldn't want to automatically have it toggle of myself. But if there are no comments, none in spam, and it's disabled? I think it shouldn't be available to toggle at all and if it had been showing, remove it.

Which is pretty close, behavior wise. And I agree, it's a nice UI enhancement.

@ic360-com
Copy link
Author

Yes, it needs some kind of 'overall' control I think. I'm sure this used to be included in the CP somewhere / somehow pre-V6.

eg. If you have 100 channels, then setting the Entries List view manually, to remove the Comments column, will be a pain, if you decide not to be using Comments on the site anymore... whether there are Entries with pre-existing Comments or not.

intoeetive added a commit that referenced this issue Nov 30, 2022
matthewjohns0n added a commit that referenced this issue Dec 12, 2022
…column-when-comments-disabled

Resolved #2080 where Comments column was shown in Entry Manager when Comment module is disabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants