Skip to content

New regression in grid.js in latest 7.x release #2758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
litzinger opened this issue Jan 16, 2023 · 1 comment · Fixed by #2770
Closed

New regression in grid.js in latest 7.x release #2758

litzinger opened this issue Jan 16, 2023 · 1 comment · Fixed by #2770
Assignees
Labels
Bug: Accepted Bug has been confirmed, is reproducible, and ready to work on.

Comments

@litzinger
Copy link
Contributor

Description of the problem
I described the issue here: 2753192

Anyone using the Grid or MiniGrid services might be affected by this. It seems to work fine if the html for the Grid is already on the page, but if a Grid is added dynamically, the sorting is not properly bound to that Grid instance. The selector used in that change tries to find any tbody on the page and make it sortable.

I'm not sure what was wrong with the old code that prompted that change, but it's adversely affecting Simple Grids & Tables.

How To Reproduce
Steps to reproduce the behavior:
Use JS to dynamically add a Grid field to the page, note that sorting does not work.

Possible Solutions

  1. Replace $('tbody') selector with whatever the variable is for the instance of the Grid field.
  2. Revert that commit
  3. Move that sortable() call into it's own function so it can be easily called and bound to a Grid field dynamically added to the page.
@litzinger
Copy link
Contributor Author

I can provide a copy of SG&T if it helps in reproducing the issue. Or you could probably grab a zip from the EE add-ons site :)

@Yulyaswan Yulyaswan added the Bug: Accepted Bug has been confirmed, is reproducible, and ready to work on. label Jan 19, 2023
intoeetive added a commit that referenced this issue Jan 27, 2023
…ssue

Resolved #2758 where reordering did not always work properly in third-party grids
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Accepted Bug has been confirmed, is reproducible, and ready to work on.
Projects
None yet
2 participants