Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling Front End Editing (EE6) kills some relationship field rendering #3035

Closed
jcogs-design opened this issue Feb 22, 2023 · 9 comments · Fixed by #3049
Closed

Enabling Front End Editing (EE6) kills some relationship field rendering #3035

jcogs-design opened this issue Feb 22, 2023 · 9 comments · Fixed by #3049
Assignees

Comments

@jcogs-design
Copy link
Contributor

jcogs-design commented Feb 22, 2023

Description of the problem
Enabling 'Front End Editing' as an option in the EEPro add-on (licensed) in EE6 causes some relationship fields to fail to render.

See the before / after images attached.
Screenshot 2023-02-22 at 14 19 38
Screenshot 2023-02-22 at 14 20 11

How To Reproduce
Steps to reproduce the behavior:
Enable Front-End editing in EEPro add-on and reload page.

Environment Details:

  • Version: 6.4.5
  • PHP Version 8.0.27
  • MySQL Version MySQL 8.0.32
  • OS: ?
  • Web Server: Litespeed (Apache)
@intoeetive
Copy link
Contributor

@jcogs-design Can you send over the template code? And what fieldtypes are involved here (specifically interested in Grid, Fluid and Relationships)

@jcogs-design
Copy link
Contributor Author

Might be easiest for you to poke around on the site directly - DM me if you want some access credentials. But roughly...

The parent page contains a relationship field (content_block_linker) that links to (among other things) an entry in a channel that contains two grid fields (content_block_ctas and comparison_table_footer_text).

HTH.

@intoeetive intoeetive self-assigned this Feb 22, 2023
@jcogs-design
Copy link
Contributor Author

jcogs-design commented Feb 22, 2023

Just to add to this, have just noticed that in addition, a Wygwam and Text Input field (both with Front End Editing enabled) from an entry in channel do not show edit tags when Front End Editing is enabled. The text input field is the orange heading in the image, the Wygwam field the text block below. The entry containing the fields is in a channel entries of which are collated in a relationship field in an entry from another channel, and that entry is included in the same 'content_block_linker' relationship field mentioned above. The edit tag showing in the image is for the parent Relationship field (i.e. "content block linker").
Screenshot 2023-02-22 at 18 50 58

@intoeetive
Copy link
Contributor

intoeetive commented Feb 23, 2023

@jcogs-design can you try applying the change in this PR and see if that helps? (this is for v7 but the corresponding code is the same)

https://github.com/ExpressionEngine/ExpressionEngine/pull/3037/files#diff-a7429b2609d058d5df52b25e0197e0406aebb5850bd102e2fd9712512259aaf8R222-R233

@jcogs-design
Copy link
Contributor Author

Sure - will try and get to it later today and report back

@intoeetive
Copy link
Contributor

sorry - please hold off testing, I found an issue with that supposed-to-be-fix. I'll keep you updated

@jcogs-design
Copy link
Contributor Author

OK - np

@jcogs-design
Copy link
Contributor Author

Sadly not... :(
Replaced the code for FrontEdit.php with your modified version on the test server and got these results
Without front edit enabled on two bottom grid fields
image
With front edit enabled on two bottom grid fields
image

intoeetive added a commit that referenced this issue Feb 28, 2023
…ates could cause some tags to be not parsed
intoeetive added a commit that referenced this issue Feb 28, 2023
…ates could cause some tags to be not parsed
matthewjohns0n added a commit that referenced this issue Mar 1, 2023
…lex-templates-issue

Resolved #3035 where enabling front-end editing on very complex templates could cause some tags to be not parsed
intoeetive added a commit that referenced this issue Mar 2, 2023
…ates could cause some tags to be not parsed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants