Skip to content

Duplicated line of code in AbstractDesign.php #4491

@jcogs-design

Description

@jcogs-design

Description of the problem
Not really a problem, just an observation.
In the file system/ee/ExpressionEngine/Controller/Design/AbstractDesign.php there is a near-duplicated line.
Here are lines 462 and 463 of the referenced file:

            $edit_url = ee('CP/URL')->make('design/template/edit/' . $template->template_id);
            $edit_url = ee('CP/URL', 'design/template/edit/' . $template->template_id);

The first of these two lines will execute, but unless I'm missing something (e.g. some unseen 'side-effect' taking place) the first of these two lines is redundant.

Environment Details:

  • Version: 7.4.11
  • PHP Version 8.3

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions