Skip to content

Deleting a template group's index results in a confirmation but also fails #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
murtaugh opened this issue Sep 25, 2020 · 3 comments · Fixed by #3391
Closed

Deleting a template group's index results in a confirmation but also fails #532

murtaugh opened this issue Sep 25, 2020 · 3 comments · Fixed by #3391

Comments

@murtaugh
Copy link
Contributor

In EE 5.3.2 I tried to delete the index template of a template group. I got a message that it was successful, but it still existed.

How To Reproduce

  1. Create template group.
  2. Delete the index template.
  3. You get a confirmation message, but will fail.

Screen Shot 2020-09-25 at 2 34 52 PM

I actually presume this is the intended behavior, in which case the message should be an error instead of a confirmation.

@intoeetive
Copy link
Contributor

The template is actually being deleted, it's just being recreated right after (if you check the contents, it should be empty) - and this happens if you have "set templates as files" setting turned on.

So as such, the message is correct

Do you think there needs to be another message saying the template has been automatically created? (I'd say no)

@murtaugh
Copy link
Contributor Author

murtaugh commented Oct 9, 2020

Makes sense, but I think the fact that index pages have a special status that isn't reflected in the UI results in confusion.

Here are some thoughts, some good, some maybe not:

  • When editing an index template, place a small note on the Edit Template page informing users about the nature of index templates.
  • Make index templates un-deletable via the CP. Users can still clear them out if they want.
  • If a user tries to delete the file and it reappears, perhaps put a comment in the file itself explaining the continued existence of the file.
  • Make empty/missing index files redirect to the home page.

@intoeetive
Copy link
Contributor

Thank you - I'll pass these with the team and we'll see which is the better path to improve things

@intoeetive intoeetive added the enhancement New feature or request label Oct 12, 2020
@intoeetive intoeetive added enhancement: accepted and removed enhancement New feature or request labels Aug 12, 2021
intoeetive added a commit to ExpressionEngine/ExpressionEngine-User-Guide that referenced this issue May 15, 2023
bryannielsen added a commit that referenced this issue Aug 14, 2023
…ng-index-template

Resolved #532 where index template could be deleted but then immediately recreated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants