Conversation
Contributor
|
I hacked all over the place trying to get the cp reading that as a critical update. I can make it return red in the ajax little modal thing: But never in the sidebar: 
That was the case for all the themes. I'm either not triggering it to be 'vital' or they're all just not showing an indicator. Controller/settings/general.php is the main place I changed it: 
But I played around a lot. Need to figure out how to set it and know it's set as a 'critical update' to test. |
Contributor
|
Well mine was weird, but I paired with @bakin1999 and screen share shows all is well! Approved. |
robinsowell
approved these changes
Feb 27, 2025
bakin1999
approved these changes
Feb 27, 2025
Collaborator
bakin1999
left a comment
bakin1999
left a comment
There was a problem hiding this comment.
worked correctly for me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slate theme
Snow theme (light)
