Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Pointers): ensure correct order for pointer actions - fixes #2027 #2029

Merged
merged 1 commit into from Jun 9, 2019

Conversation

Projects
None yet
2 participants
@thestonefox
Copy link
Member

commented Jun 7, 2019

There was a race condition where the activation action could be
registered before the selection action meaning doing things like
select on release would not work as the activation action was
being called before the selection action so the pointer would be
disabled before it could select anything.

This fix moves around some of the registration logic to ensure
the correct order for actions.

fix(Pointers): ensure correct order for pointer actions
There was a race condition where the activation action could be
registered before the selection action meaning doing things like
select on release would not work as the activation action was
being called before the selection action so the pointer would be
disabled before it could select anything.

This fix moves around some of the registration logic to ensure
the correct order for actions.

@thestonefox thestonefox requested a review from bddckr Jun 7, 2019

@thestonefox thestonefox changed the title fix(Pointers): ensure correct order for pointer actions fix(Pointers): ensure correct order for pointer actions - fixes #2027 Jun 7, 2019

@bddckr

bddckr approved these changes Jun 7, 2019

@thestonefox thestonefox merged commit 6e769d4 into master Jun 9, 2019

1 check passed

WIP Ready for review
Details

@thestonefox thestonefox deleted the fix/pointer-selection branch Jun 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.