diff --git a/mlrun/common/model_monitoring/helpers.py b/mlrun/common/model_monitoring/helpers.py index 34b32f82b7a..9b8ea3cab0b 100644 --- a/mlrun/common/model_monitoring/helpers.py +++ b/mlrun/common/model_monitoring/helpers.py @@ -82,13 +82,15 @@ def parse_monitoring_stream_path( if application_name is None: stream_uri = ( mlrun.mlconf.model_endpoint_monitoring.default_http_sink.format( - project=project + project=project, namespace=mlrun.mlconf.namespace ) ) else: stream_uri = ( mlrun.mlconf.model_endpoint_monitoring.default_http_sink_app.format( - project=project, application_name=application_name + project=project, + application_name=application_name, + namespace=mlrun.mlconf.namespace, ) ) return stream_uri diff --git a/mlrun/config.py b/mlrun/config.py index a5a01119cab..4d7021f7180 100644 --- a/mlrun/config.py +++ b/mlrun/config.py @@ -487,8 +487,8 @@ "offline_storage_path": "model-endpoints/{kind}", # Default http path that points to the monitoring stream nuclio function. Will be used as a stream path # when the user is working in CE environment and has not provided any stream path. - "default_http_sink": "http://nuclio-{project}-model-monitoring-stream.mlrun.svc.cluster.local:8080", - "default_http_sink_app": "http://nuclio-{project}-{application_name}.mlrun.svc.cluster.local:8080", + "default_http_sink": "http://nuclio-{project}-model-monitoring-stream.{namespace}.svc.cluster.local:8080", + "default_http_sink_app": "http://nuclio-{project}-{application_name}.{namespace}.svc.cluster.local:8080", "batch_processing_function_branch": "master", "parquet_batching_max_events": 10_000, "parquet_batching_timeout_secs": timedelta(minutes=1).total_seconds(), diff --git a/mlrun/model_monitoring/batch.py b/mlrun/model_monitoring/batch.py index 8688a96663d..86ad4120fd3 100644 --- a/mlrun/model_monitoring/batch.py +++ b/mlrun/model_monitoring/batch.py @@ -992,7 +992,7 @@ def _update_drift_in_prometheus( """ stream_http_path = ( mlrun.mlconf.model_endpoint_monitoring.default_http_sink.format( - project=self.project + project=self.project, namespace=mlrun.mlconf.namespace ) ) diff --git a/tests/model_monitoring/test_target_path.py b/tests/model_monitoring/test_target_path.py index 57ed9288864..0c03b98db36 100644 --- a/tests/model_monitoring/test_target_path.py +++ b/tests/model_monitoring/test_target_path.py @@ -67,7 +67,7 @@ def test_get_stream_path(): stream_path = mlrun.model_monitoring.get_stream_path(project=TEST_PROJECT) assert ( stream_path - == f"http://nuclio-{TEST_PROJECT}-model-monitoring-stream.mlrun.svc.cluster.local:8080" + == f"http://nuclio-{TEST_PROJECT}-model-monitoring-stream.{mlrun.mlconf.namespace}.svc.cluster.local:8080" ) # kafka stream path from env