Refactor command packet marshalling #145

Closed
eile opened this Issue Jul 26, 2012 · 3 comments

Projects

None yet

2 participants

@eile
Member
eile commented Jul 26, 2012

Main drivers are endian awareness and ease of use.

Remove the packets from the public API, replacing them by a DataO/IStream-based API:

node << Command( name ) << requestID << Blob( ptr, size ) << end; // fills in NodeID and packet type
object << ...; // fills in ObjectID, forwards to node

bool Node::_cmdName( DataIStream& is )
{
    is >> requestID >> blob;
    ...
    _cache.addData( is );
}
@eile
Member
eile commented Jul 26, 2012

Issue 1: DataIStream needs to retain all packets until command handler is left

... in contrast to the object IStreams, which release immediately. Reason is that some is will be redispatched to other users.

@tribal-tec tribal-tec was assigned Aug 9, 2012
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 13, 2012
@tribal-tec tribal-tec Fix wrong unpacking of Object* (Eyescale/Equalizer#145) 6267c80
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 16, 2012
@tribal-tec tribal-tec Migrate queue item packet (Eyescale/Equalizer#145) d924c32
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 16, 2012
@tribal-tec tribal-tec Cleanup obsolete functions (Eyescale/Equalizer#145) e5bc43a
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 17, 2012
@tribal-tec tribal-tec Pimpl for co::Command (Eyescale/Equalizer#145) ea5d980
@eile eile added a commit to Eyescale/Collage that referenced this issue Aug 17, 2012
@eile eile Partial review of Eyescale/Equalizer#145 5dcbcfe
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 20, 2012
@tribal-tec tribal-tec Separate storage from Command to new co::Buffer, Command is a stream-…
…based now, no more packets anymore (Eyescale/Equalizer#145)
25e3ce3
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 20, 2012
@tribal-tec tribal-tec Minor cleanups, fix release build (Eyescale/Equalizer#145) 6f6d61d
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 20, 2012
@tribal-tec tribal-tec Fix Buffer clone & fix memleak (Eyescale/Equalizer#145) 475e20a
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 20, 2012
@tribal-tec tribal-tec Start on migrating to new Collage stream commands, done with eq/fabri…
…c/serverPackets (Eyescale/Equalizer#145)
bb56699
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 20, 2012
@tribal-tec tribal-tec Migrated eq/fabric/config^Cckets (Eyescale/Equalizer#145) bae3ab3
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 20, 2012
@tribal-tec tribal-tec Migrated more fabric packets (Eyescale/Equalizer#145) 6628394
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 20, 2012
@tribal-tec tribal-tec Migrate admin packets (Eyescale/Equalizer#145) f254299
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 20, 2012
@tribal-tec tribal-tec Migrate client/clientPackets (Eyescale/Equalizer#145) 9f0e737
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 20, 2012
@tribal-tec tribal-tec Migrate client/viewPackets (Eyescale/Equalizer#145) adb580d
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 20, 2012
@tribal-tec tribal-tec Fix for Equalizer build (Eyescale/Equalizer#145) 47c2f26
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 21, 2012
@tribal-tec tribal-tec Migrate client/configPackets (Eyescale/Equalizer#145) 38a6a6c
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 21, 2012
@tribal-tec tribal-tec Migrate client/pipePackets (Eyescale/Equalizer#145) d603e23
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 21, 2012
@tribal-tec tribal-tec Migrate client/windowPackets (Eyescale/Equalizer#145) e232c4d
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 21, 2012
@tribal-tec tribal-tec Migrate client/channelPackets (Eyescale/Equalizer#145) 2dd73d8
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 22, 2012
@tribal-tec tribal-tec Fix clang build (Eyescale/Equalizer#145) 084cbbd
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 22, 2012
@tribal-tec tribal-tec Fix configVisitor unit test (Eyescale/Equalizer#145) 122f002
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 22, 2012
@tribal-tec tribal-tec Fix configUpdate unit test (Eyescale/Equalizer#145) d42e248
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 22, 2012
@tribal-tec tribal-tec Fix local eqPly run (Eyescale/Equalizer#145) 958efc2
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 22, 2012
@tribal-tec tribal-tec Use correct command type for reply (Eyescale/Equalizer#145) 4a97137
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 22, 2012
@tribal-tec tribal-tec Fix command send (Eyescale/Equalizer#145) 003d770
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 22, 2012
@tribal-tec tribal-tec Fix unlocked send (Eyescale/Equalizer#145) 2dfe1ec
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 28, 2012
@tribal-tec tribal-tec Cleanup compressed data send (Eyescale/Equalizer#145) c5db542
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 28, 2012
@tribal-tec tribal-tec Fix assertion (Eyescale/Equalizer#145) 2020485
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 28, 2012
@tribal-tec tribal-tec Add todos (Eyescale/Equalizer#145) 577be40
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 28, 2012
@tribal-tec tribal-tec Maintain const correctness (Eyescale/Equalizer#145) 9adb4d5
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 28, 2012
@tribal-tec tribal-tec Migrate ConfigEvent (Eyescale/Equalizer#145) 0a93c9b
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 28, 2012
@tribal-tec tribal-tec Fix order of execution (Eyescale/Equalizer#145) e37942e
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 28, 2012
@tribal-tec tribal-tec Build fix (Eyescale/Equalizer#145) c8083d7
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 29, 2012
@tribal-tec tribal-tec Fix tile rendering (Eyescale/Equalizer#145) a1318fb
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 29, 2012
@tribal-tec tribal-tec Fix wrong command unpack (Eyescale/Equalizer#145) 3bdd472
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 29, 2012
@tribal-tec tribal-tec Simplify NodeOCommand usage (Eyescale/Equalizer#145) 514349f
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 29, 2012
@tribal-tec tribal-tec Adapt to recent Collage changes (Eyescale/Equalizer#145) 813d00d
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 29, 2012
@tribal-tec tribal-tec Fix admin client commands (Eyescale/Equalizer#145) 7c76610
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 29, 2012
@tribal-tec tribal-tec Fix init reply commands (Eyescale/Equalizer#145) 47a2f43
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 29, 2012
@tribal-tec tribal-tec Minor cleanups (Eyescale/Equalizer#145) 10b550c
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 29, 2012
@tribal-tec tribal-tec Documentation todos & tweaks (Eyescale/Equalizer#145) 22adc5b
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 29, 2012
@tribal-tec tribal-tec Documentation todos & tweaks (Eyescale/Equalizer#145) dc08144
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 30, 2012
@tribal-tec tribal-tec Add static size gathering to OCommands for proper allocation through …
…command cache & local dispatch (Eyescale/Equalizer#145)
33e4caa
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 30, 2012
@tribal-tec tribal-tec Fix clang build (Eyescale/Equalizer#145) 223cc60
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 30, 2012
@tribal-tec tribal-tec Fix mem leaks (Eyescale/Equalizer#145) 1b4e397
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 30, 2012
@tribal-tec tribal-tec Cleaner local command dispatch (Eyescale/Equalizer#145) 3ea8b7c
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 30, 2012
@tribal-tec tribal-tec Doxygen fixes (Eyescale/Equalizer#145) c858aef
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Sep 1, 2012
@tribal-tec tribal-tec Fix Win32 build(Eyescale/Equalizer#145) 22df1c4
@eile eile added a commit to Eyescale/Collage that referenced this issue Sep 3, 2012
@eile eile Merge cleanups for Eyescale/Equalizer#145 626cc14
@eile eile referenced this issue in Eyescale/Collage Sep 3, 2012
Closed

Avoid copy of large data during send #9

@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Sep 3, 2012
@tribal-tec tribal-tec Rename commandCache -> bufferCache (Eyescale/Equalizer#145) 44c15f1
@eile eile added a commit to Eyescale/Collage that referenced this issue Sep 3, 2012
@eile eile Merge cleanups for Eyescale/Equalizer#145 e41931b
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Sep 4, 2012
@tribal-tec tribal-tec Use local dispatch again (Eyescale/Equalizer#145) 8991722
@eile eile added a commit to Eyescale/Collage that referenced this issue Sep 4, 2012
@eile eile Merge cleanups for Eyescale/Equalizer#145 5aa1a8e
@eile eile added a commit that referenced this issue Sep 4, 2012
@eile eile Merge cleanups for #145 b60cc04
@eile eile added a commit to Eyescale/Collage that referenced this issue Sep 4, 2012
@eile eile Merge cleanups for Eyescale/Equalizer#145 1750c3a
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Sep 4, 2012
@tribal-tec tribal-tec Merge cleanups for #145 c9ff4b5
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Sep 4, 2012
@tribal-tec tribal-tec Resolve open issues (Eyescale/Equalizer#145) d6f4022
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Sep 4, 2012
@tribal-tec tribal-tec Merge cleanups for Eyescale/Equalizer#145 e5ff24c
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Sep 4, 2012
@tribal-tec tribal-tec Merge cleanups for Eyescale/Equalizer#145 1ad69f2
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Sep 4, 2012
@tribal-tec tribal-tec Merge cleanups for #145 a3125c8
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Sep 4, 2012
@tribal-tec tribal-tec Fix Win32 build (Eyescale/Equalizer#145) d93cc0d
@eile eile added a commit to Eyescale/Collage that referenced this issue Sep 5, 2012
@eile eile Merge cleanups for Eyescale/Equalizer#145 84716fd
@eile eile added a commit to Eyescale/Collage that referenced this issue Sep 5, 2012
@eile eile Merge cleanups for Eyescale/Equalizer#145 8ca79d6
@eile eile added a commit that referenced this issue Sep 5, 2012
@eile eile Merge cleanups for Eyescale/Equalizer#145 d43b305
@eile eile added a commit to Eyescale/Collage that referenced this issue Sep 5, 2012
@eile eile const correctness for Eyescale/Equalizer#145 d6227de
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Sep 5, 2012
@tribal-tec tribal-tec There are no packets anymore... (Eyescale/Equalizer#145) 9245213
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Sep 5, 2012
@tribal-tec tribal-tec Rename packet -> command (#145) 37d4343
@eile eile added a commit to Eyescale/Collage that referenced this issue Sep 6, 2012
@eile eile Merge cleanups for Eyescale/Equalizer#145 280bda6
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Sep 6, 2012
@tribal-tec tribal-tec Resolve todo (#145) 539c065
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Sep 6, 2012
@tribal-tec tribal-tec New API for config events, maintain old API, port examples, fix event…
… related issues (#145)
e8c6f0b
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Sep 6, 2012
@tribal-tec tribal-tec Bump version, documentation tweaks (Eyescale/Equalizer#145) 5e7e1c5
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Sep 6, 2012
@tribal-tec tribal-tec Bump version, documentation tweaks (#145) d748579
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Sep 6, 2012
@tribal-tec tribal-tec Tweak event sending: only use type, append Event data only for built-…
…in events (#145)
dda718e
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Sep 6, 2012
@tribal-tec tribal-tec Fix Win32 build (#145) 9c19e81
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Sep 7, 2012
@tribal-tec tribal-tec Simplify Node::send (Eyescale/Equalizer#145) b5384e3
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Sep 7, 2012
@tribal-tec tribal-tec Simplify send of server commands, remove obsolete server command disp…
…atching (#145)
a97ab7a
@eile eile added a commit that referenced this issue Sep 7, 2012
@eile eile Partial CR for #145 3969491
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Sep 10, 2012
@tribal-tec tribal-tec Resolve todo (#145) 2ab4e96
@eile eile referenced this issue in Eyescale/Collage Sep 11, 2012
Closed

Custom Node commands weirdness #10

@eile eile added a commit to Eyescale/Collage that referenced this issue Sep 14, 2012
@eile eile Eyescale/Equalizer#145: Optimize number of send calls by moving size …
…into buffer
35c4742
@eile eile added a commit to Eyescale/Collage that referenced this issue Sep 20, 2012
@eile eile Eyescale/Equalizer#145: rename Command->ICommand cfecaf5
@eile eile added a commit that referenced this issue Sep 20, 2012
@eile eile Adapt to latest Collage (#145) 161a7ad
@eile
Member
eile commented Oct 2, 2012

Trying to close this one. Grep shows the following open issues:

./co/types.h:typedef ICommand Command; //TODO 145 rename internally.
./co/oCommand.cpp: // #145 proper local command dispatch?

The first one can be postponed, not sure about the second.

@tribal-tec ?

@eile eile added a commit to Eyescale/Collage that referenced this issue Oct 2, 2012
@eile eile Minor cleanup (Eyescale/Equalizer#145) b332610
@tribal-tec tribal-tec added a commit to tribal-tec/Collage that referenced this issue Oct 2, 2012
@tribal-tec tribal-tec Rename *Command -> *ICommand (Eyescale/Equalizer#145) 8df6653
@tribal-tec tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Oct 2, 2012
@tribal-tec tribal-tec Rename *Command -> *ICommand (Eyescale/Equalizer#145) a209679
@tribal-tec
Member
  1. done with tribal-tec/Collage@8df6653 and tribal-tec@a209679
  2. leave it as todo for the time being
@eile eile closed this Oct 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment