New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor command packet marshalling #145

Closed
eile opened this Issue Jul 26, 2012 · 3 comments

Comments

Projects
None yet
2 participants
@eile
Member

eile commented Jul 26, 2012

Main drivers are endian awareness and ease of use.

Remove the packets from the public API, replacing them by a DataO/IStream-based API:

node << Command( name ) << requestID << Blob( ptr, size ) << end; // fills in NodeID and packet type
object << ...; // fills in ObjectID, forwards to node

bool Node::_cmdName( DataIStream& is )
{
    is >> requestID >> blob;
    ...
    _cache.addData( is );
}
@eile

This comment has been minimized.

Show comment
Hide comment
@eile

eile Jul 26, 2012

Member

Issue 1: DataIStream needs to retain all packets until command handler is left

... in contrast to the object IStreams, which release immediately. Reason is that some is will be redispatched to other users.

Member

eile commented Jul 26, 2012

Issue 1: DataIStream needs to retain all packets until command handler is left

... in contrast to the object IStreams, which release immediately. Reason is that some is will be redispatched to other users.

@ghost ghost assigned tribal-tec Aug 9, 2012

tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 13, 2012

tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 13, 2012

tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 13, 2012

tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 15, 2012

tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 16, 2012

tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 16, 2012

tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 16, 2012

tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 16, 2012

tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 17, 2012

tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 17, 2012

tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 17, 2012

eile added a commit to Eyescale/Collage that referenced this issue Aug 17, 2012

tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 20, 2012

tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 20, 2012

tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 20, 2012

tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 20, 2012

tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 20, 2012

tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 20, 2012

tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 20, 2012

tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 20, 2012

tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 20, 2012

tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 20, 2012

tribal-tec added a commit to tribal-tec/Collage that referenced this issue Aug 20, 2012

tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 21, 2012

tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 21, 2012

tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 21, 2012

tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 21, 2012

tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 21, 2012

tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Aug 22, 2012

eile added a commit to Eyescale/Collage that referenced this issue Sep 4, 2012

tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Sep 4, 2012

tribal-tec added a commit to tribal-tec/Collage that referenced this issue Sep 4, 2012

tribal-tec added a commit to tribal-tec/Collage that referenced this issue Sep 4, 2012

tribal-tec added a commit to tribal-tec/Collage that referenced this issue Sep 4, 2012

tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Sep 4, 2012

tribal-tec added a commit to tribal-tec/Collage that referenced this issue Sep 4, 2012

tribal-tec added a commit to tribal-tec/Collage that referenced this issue Sep 4, 2012

eile added a commit to Eyescale/Collage that referenced this issue Sep 5, 2012

eile added a commit to Eyescale/Collage that referenced this issue Sep 5, 2012

eile added a commit that referenced this issue Sep 5, 2012

eile added a commit to Eyescale/Collage that referenced this issue Sep 5, 2012

tribal-tec added a commit to tribal-tec/Collage that referenced this issue Sep 5, 2012

tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Sep 5, 2012

eile added a commit to Eyescale/Collage that referenced this issue Sep 6, 2012

tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Sep 6, 2012

tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Sep 6, 2012

tribal-tec added a commit to tribal-tec/Collage that referenced this issue Sep 6, 2012

tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Sep 6, 2012

tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Sep 6, 2012

tribal-tec added a commit to tribal-tec/Collage that referenced this issue Sep 6, 2012

tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Sep 6, 2012

tribal-tec added a commit to tribal-tec/Collage that referenced this issue Sep 7, 2012

tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Sep 7, 2012

eile added a commit that referenced this issue Sep 7, 2012

eile added a commit that referenced this issue Sep 10, 2012

tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Sep 10, 2012

tribal-tec added a commit to BlueBrain/codash that referenced this issue Sep 10, 2012

eile added a commit to Eyescale/Collage that referenced this issue Sep 14, 2012

eile added a commit to Eyescale/Collage that referenced this issue Sep 20, 2012

eile added a commit that referenced this issue Sep 20, 2012

@eile

This comment has been minimized.

Show comment
Hide comment
@eile

eile Oct 2, 2012

Member

Trying to close this one. Grep shows the following open issues:

./co/types.h:typedef ICommand Command; //TODO 145 rename internally.
./co/oCommand.cpp: // #145 proper local command dispatch?

The first one can be postponed, not sure about the second.

@tribal-tec ?

Member

eile commented Oct 2, 2012

Trying to close this one. Grep shows the following open issues:

./co/types.h:typedef ICommand Command; //TODO 145 rename internally.
./co/oCommand.cpp: // #145 proper local command dispatch?

The first one can be postponed, not sure about the second.

@tribal-tec ?

eile added a commit to Eyescale/Collage that referenced this issue Oct 2, 2012

tribal-tec added a commit to tribal-tec/Collage that referenced this issue Oct 2, 2012

tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Oct 2, 2012

@tribal-tec

This comment has been minimized.

Show comment
Hide comment
@tribal-tec

tribal-tec Oct 2, 2012

Member
  1. done with tribal-tec/Collage@8df6653 and tribal-tec@a209679
  2. leave it as todo for the time being
Member

tribal-tec commented Oct 2, 2012

  1. done with tribal-tec/Collage@8df6653 and tribal-tec@a209679
  2. leave it as todo for the time being

@eile eile closed this Oct 2, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment