From 431ac5b6a124e1bbeb65a89dce9c2db8b7b82dea Mon Sep 17 00:00:00 2001
From: a-laurowski <Panpiczek1!>
Date: Wed, 9 Jan 2019 08:04:09 +0100
Subject: [PATCH] FFWEB-1007 : Remove 'keep-filter' parameter from module
 configuration

---
 CHANGELOG                                     | 3 +++
 Omikron/Factfinder/Block/FF/Communication.php | 5 -----
 Omikron/Factfinder/Helper/Data.php            | 9 ---------
 Omikron/Factfinder/etc/adminhtml/system.xml   | 5 -----
 4 files changed, 3 insertions(+), 19 deletions(-)

diff --git a/CHANGELOG b/CHANGELOG
index f489741e..58301a56 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -3,6 +3,9 @@
 - Add missing title to `factfinder_result_index` site
 - Exclude FACT-Finder Web Components js script from minification
 
+## CHANGE
+- Remove 'keep-filters' parameter from module configuration
+
 #ADD
 - Added possibility to export additional attributes in separate columns
 - Adds possibility to configure frequency of feed file generation by Cron
diff --git a/Omikron/Factfinder/Block/FF/Communication.php b/Omikron/Factfinder/Block/FF/Communication.php
index 1cbc2f82..09b2ffe4 100644
--- a/Omikron/Factfinder/Block/FF/Communication.php
+++ b/Omikron/Factfinder/Block/FF/Communication.php
@@ -104,11 +104,6 @@ public function __construct(
                 'type' => 'string',
                 'defaultValue' => $defaultValues['advanced']['add_tracking_params']
             ],
-            'keep-filters' => [
-                'value' => $this->_helper->getKeepFilters(),
-                'type' => 'boolean',
-                'defaultValue' => $defaultValues['advanced']['keep_filters']
-            ],
             'keep-url-params' => [
                 'value' => $this->_helper->getKeepUrlParams(),
                 'type' => 'string',
diff --git a/Omikron/Factfinder/Helper/Data.php b/Omikron/Factfinder/Helper/Data.php
index f162a705..6e097a41 100644
--- a/Omikron/Factfinder/Helper/Data.php
+++ b/Omikron/Factfinder/Helper/Data.php
@@ -243,15 +243,6 @@ public function getAddTrackingParams()
         return $this->scopeConfig->getValue('factfinder/advanced/add_tracking_params', 'store');
     }
 
-    /**
-     * Returns the keep-filters configuration
-     * @return mixed
-     */
-    public function getKeepFilters()
-    {
-        return $this->scopeConfig->getValue('factfinder/advanced/keep_filters', 'store');
-    }
-
     /**
      * Returns the keep-url-params configuration
      * @return mixed
diff --git a/Omikron/Factfinder/etc/adminhtml/system.xml b/Omikron/Factfinder/etc/adminhtml/system.xml
index 5d2e4ec4..1551134a 100644
--- a/Omikron/Factfinder/etc/adminhtml/system.xml
+++ b/Omikron/Factfinder/etc/adminhtml/system.xml
@@ -80,11 +80,6 @@
                     <label>add-tracking-params</label>
                     <comment>With this property you can deliver standard parameters which are attached to every tracking request. Example: param1=abc,param2=xyz.</comment>
                 </field>
-                <field id="keep_filters" translate="label" type="select" sortOrder="80" showInDefault="1" showInWebsite="1" showInStore="1">
-                    <label>keep-filters</label>
-                    <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
-                    <comment>With this property you can determine if filters (which where set before the search, e.g. via ASN) should be kept or discarded.</comment>
-                </field>
                 <field id="keep_url_params" translate="label" type="text" sortOrder="90" showInDefault="1" showInWebsite="1" showInStore="1">
                     <label>keep-url-params</label>
                     <comment>Determines if parameters which are written into the URL should be kept.</comment>