Skip to content

Add php 8.2 and php 8.3 compatibility #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

duboiss
Copy link
Contributor

@duboiss duboiss commented Jan 18, 2024

Because your latest commit includes "PHP version 8.1 and higher".
I just replaced ~8.1.0 to ~8.1 (as your sdk) in order to authorize php 8.2 / php 8.3

Composer documentation :
The ~ operator is best explained by example: ~1.2 is equivalent to >=1.2 <2.0.0, while ~1.2.3 is equivalent to >=1.2.3 <1.3.0

@Rayn93
Copy link
Contributor

Rayn93 commented Jan 18, 2024

Hi @duboiss I will test SDK with PHP v8.2 and v8.3. If everything is fine I will merge your changes.

@duboiss
Copy link
Contributor Author

duboiss commented Jan 26, 2024

Hey @Rayn93 , any news ? Thanks

@Rayn93
Copy link
Contributor

Rayn93 commented Feb 5, 2024

Hi @duboiss
I noticed some problems with export feature for PHP v8.3. I will try to fix it.

@duboiss
Copy link
Contributor Author

duboiss commented Mar 21, 2024

@Rayn93 In case you don't have it, here one

Deprecated Functionality: mb_convert_encoding(): Handling HTML entities via mbstring is deprecated; use htmlspecialchars, htmlentities, or mb_encode_numericentity/mb_decode_numericentity instead in /var/www/html/vendor/omikron/magento2-factfinder/src/Model/Filter/TextFilter.php on line 17 

Co-authored-by: Fritz Michael Gschwantner <fmg@inspiredminds.at>
@Rayn93
Copy link
Contributor

Rayn93 commented Aug 28, 2024

@duboiss Support for PHP8.2 and 8.3 for SDK v4.x was added here: d4856cb

@Rayn93 Rayn93 closed this Aug 28, 2024
@duboiss
Copy link
Contributor Author

duboiss commented Aug 28, 2024

@duboiss Support for PHP8.2 and 8.3 for SDK v4.x was added here: d4856cb

Do you plan to create a new release tag ?

@Rayn93
Copy link
Contributor

Rayn93 commented Aug 29, 2024

@duboiss, yes sure. Probably next week we will prepare a new release.

@duboiss
Copy link
Contributor Author

duboiss commented Sep 9, 2024

@Rayn93 up about creating this new release, thanks :)

@Rayn93
Copy link
Contributor

Rayn93 commented Sep 9, 2024

@duboiss release is ready: https://github.com/FACT-Finder-Web-Components/magento2-module/releases/tag/v4.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants