Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically use 'foo' as password on test lobby server #712

Closed
muellni opened this issue Apr 26, 2017 · 5 comments
Closed

Automatically use 'foo' as password on test lobby server #712

muellni opened this issue Apr 26, 2017 · 5 comments
Assignees

Comments

@muellni
Copy link
Contributor

muellni commented Apr 26, 2017

One of the last annoying points in my ICE test beta client is that the user has to reenter the password when he switches back from beta to production client.
I suggest to make the client detect that the test lobby server is used and override the supplied password with foo.
This way we don't touch the stored password for production.

@Wesmania
Copy link
Contributor

I'd love to work on this on top of #653. Changing login widget stuff around in what we have currently is a pain, and it'd take just a handful of lines to implement that on top of that PR (including not having the widget snoop around the client object).

@muellni
Copy link
Contributor Author

muellni commented Apr 26, 2017

Thank you, this would be a nice to have for public ICE test. I'll rebase my ICE branch, just ping me when ready :)

@muellni
Copy link
Contributor Author

muellni commented May 2, 2017

You're using config.is_beta() but I suggest to detect using the test server instead. config.is_beta() could also be true for production server clients I guess.

@muellni muellni reopened this May 2, 2017
@Wesmania
Copy link
Contributor

Wesmania commented May 2, 2017

Am I supposed to do that by looking at the host string? is_beta() is indeed a misleading name, but it simply checks if the environment is development, and I think it's the authoritative thing in deciding if we're connecting to the test server.

@muellni
Copy link
Contributor Author

muellni commented May 2, 2017

Sorry, you're right, defaults['host'] = 'test.faforever.com' is not from my ICE branch.

@muellni muellni closed this as completed May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants