New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Smart live replays #2529
Add Smart live replays #2529
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## develop #2529 +/- ##
=============================================
+ Coverage 64.03% 64.38% +0.34%
- Complexity 4509 4582 +73
=============================================
Files 497 505 +8
Lines 19383 19481 +98
Branches 1114 1124 +10
=============================================
+ Hits 12412 12542 +130
+ Misses 6346 6304 -42
- Partials 625 635 +10
Continue to review full report at Codecov.
|
d6ae8b3
to
92b9d48
Compare
I don't understand why there are two separate buttons. Would it be possible just to have the one button? I think this is applicable for all watch buttons so see no harm in integrating it. |
I do not understand you. Are you suggesting using the MenuButton class instead of the SplitMenuButton class? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I don't think there is a reason to have two separate buttons
src/main/java/com/faforever/client/replay/LiveReplayService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/faforever/client/replay/LiveReplayService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/faforever/client/replay/LiveReplayService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/faforever/client/vault/replay/WatchButtonController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/faforever/client/vault/replay/WatchButtonController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/faforever/client/vault/replay/WatchButtonController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/faforever/client/vault/replay/WatchLiveReplaySplitMenuButton.java
Outdated
Show resolved
Hide resolved
Eh, redo it again. I will continue working on the PR after #2513 is merged only. I need ContextMenuBuilder to work with PR |
92b9d48
to
30425c4
Compare
6a9eecd
to
e42591c
Compare
5920aec
to
2e3b510
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two minor things
src/main/java/com/faforever/client/replay/LiveReplayService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/faforever/client/replay/LiveReplayService.java
Outdated
Show resolved
Hide resolved
0da818a
to
b27a6fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge this after the release just so that it can have a chance to be tested in the next alpha
…oid using the application context
add RunReplayImmediatelyMenuItemTest.java
36b07eb
to
f686f96
Compare
Co-authored-by: Ivan <v23620@gmail.com>
Closes #82
Closes #2525
Marks #1959 as outdated because the
Live Replayes
table interaction is disabled (no selection)