Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to javafx18 and java17 #2623

Merged
merged 21 commits into from Mar 22, 2022
Merged

Update to javafx18 and java17 #2623

merged 21 commits into from Mar 22, 2022

Conversation

1-alex98
Copy link
Member

No description provided.

@1-alex98 1-alex98 requested a review from Sheikah45 March 19, 2022 12:03
Sheikah45
Sheikah45 reviewed Mar 19, 2022
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
@Sheikah45 Sheikah45 changed the title Maintenance/javafx18 Update to javafx18 and java17 Mar 19, 2022
This was referenced Mar 20, 2022
Closed
Closed
@codecov
Copy link

codecov bot commented Mar 20, 2022 •
edited

Codecov Report

Merging #2623 (1a77371) into develop (49c7b9f) will increase coverage by 0.16%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #2623      +/-   ##
=============================================
+ Coverage      64.48%   64.64%   +0.16%     
- Complexity      4656     4679      +23     
=============================================
  Files            513      513              
  Lines          19749    19806      +57     
  Branches        1140     1146       +6     
=============================================
+ Hits           12735    12804      +69     
+ Misses          6379     6357      -22     
- Partials         635      645      +10
Impacted Files Coverage Δ
...ava/com/faforever/client/fx/WebViewConfigurer.java 0.00% <0.00%> (ø)
...main/java/com/faforever/client/map/MapService.java 76.36% <0.00%> (-0.87%) ⬇️
...om/faforever/client/chat/ChannelTabController.java 81.32% <0.00%> (-0.39%) ⬇️
...com/faforever/client/replay/LiveReplayService.java 75.00% <0.00%> (-0.29%) ⬇️
...com/faforever/client/discord/JoinDiscordEvent.java 0.00% <0.00%> (ø)
...rever/client/ui/statusbar/StatusBarController.java 56.25% <0.00%> (ø)
...om/faforever/client/game/CreateGameController.java 75.92% <0.00%> (+0.37%) ⬆️
...orever/client/discord/JoinDiscordEventHandler.java 8.92% <0.00%> (+3.92%) ⬆️
...forever/client/chat/AbstractChatTabController.java 78.51% <0.00%> (+9.64%) ⬆️
...va/com/faforever/client/chat/ChatUserListCell.java 86.66% <0.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49c7b9f...1a77371. Read the comment docs.

@Sheikah45
Copy link
Member

Seems to be passing now

@Sheikah45
Copy link
Member

Now just have to fix the styling of the client

@Sheikah45 Sheikah45 marked this pull request as ready for review March 21, 2022 16:19
@Sheikah45 Sheikah45 temporarily deployed to deploy March 22, 2022 00:11 Inactive
@Sheikah45 Sheikah45 temporarily deployed to deploy March 22, 2022 00:28 Inactive
@Sheikah45 Sheikah45 temporarily deployed to deploy March 22, 2022 00:45 Inactive
@Sheikah45 Sheikah45 self-requested a review March 22, 2022 01:51
@Sheikah45 Sheikah45 merged commit f26ed8c into develop Mar 22, 2022
@Sheikah45 Sheikah45 deleted the maintenance/javafx18 branch March 22, 2022 02:12
@1-alex98
Copy link
Member Author

🔝

@1-alex98 1-alex98 linked an issue Mar 22, 2022 that may be closed by this pull request
Update to JavaFX 18 and use transparent WebView #2614
Closed
@Sheikah45
Copy link
Member

🔝

?

@1-alex98
Copy link
Member Author

Was meant like a well done

mrchris2000 pushed a commit to mrchris2000/downlords-faf-client that referenced this pull request Apr 15, 2022
@1-alex98
Update to javafx18 and java17 (FAForever#2623)
433cfa1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sheikah45 Sheikah45 Sheikah45 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to JavaFX 18 and use transparent WebView
2 participants
@1-alex98 @Sheikah45