Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added toggle option to disable chat colors, fixed factional font colo… #2593

Merged
merged 1 commit into from Oct 1, 2018

Conversation

@Rackover
Copy link
Member

Rackover commented Sep 25, 2018

…r, fixed observer color

@shalkya

This comment has been minimized.

Copy link
Member

shalkya commented Sep 25, 2018

image
can you pls remove the bold, and make the toggle on by default.

@Rackover Rackover force-pushed the Rackover:chat_color_options branch from d0ef4b6 to 1351a92 Sep 26, 2018
@shalkya

This comment has been minimized.

Copy link
Member

shalkya commented Sep 26, 2018

image

there is an issue with bold still ?

@Rackover

This comment has been minimized.

Copy link
Member Author

Rackover commented Sep 26, 2018

I thought you wanted boldness to disable only when the factional font color was enabled...

@shalkya

This comment has been minimized.

Copy link
Member

shalkya commented Sep 26, 2018

never said anything like that xD
i just said you make a toggle :
if on => we get your full addition (color + bold)
if off => we let people get the lobby as before.

@Rackover Rackover force-pushed the Rackover:chat_color_options branch from 1351a92 to c2906ee Oct 1, 2018
…r, fixed observer color
@shalkya shalkya changed the base branch from develop to deploy/develop Oct 1, 2018
@shalkya shalkya changed the base branch from deploy/develop to deploy/fafdevelop Oct 1, 2018
@shalkya

This comment has been minimized.

Copy link
Member

shalkya commented Oct 1, 2018

tested and behave as expected.

@shalkya shalkya merged commit 1b60ec6 into FAForever:deploy/fafdevelop Oct 1, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.