Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter queue pop times #481

Merged
merged 11 commits into from Aug 30, 2019
Merged

Conversation

@Askaholic
Copy link
Collaborator

Askaholic commented Jul 27, 2019

The previous queue pop time calculations were pretty arbitrary. This method is based on trying to achieve a certain number of players in the queue for matching, based on the observed rate of players queuing for matchmaker. In other words, the queue pop timer tries to adjust the pop times so that there are always a constant number of people in the queue.

Askaholic added 4 commits Jul 27, 2019
…layers
Emperically, the queue almost never hits 8 people in 3 minutes
@Askaholic Askaholic requested a review from Rackover Jul 27, 2019
Askaholic added 3 commits Jul 27, 2019
Copy link

norraxx left a comment

Some questions inside

server/matchmaker/pop_timer.py Show resolved Hide resolved
server/matchmaker/matchmaker_queue.py Outdated Show resolved Hide resolved
server/matchmaker/pop_timer.py Show resolved Hide resolved
Askaholic added 2 commits Aug 19, 2019
@Askaholic Askaholic force-pushed the Askaholic:smarter-queue-pop-times branch from e1c8eb2 to 2c346d8 Aug 19, 2019
@norraxx

This comment has been minimized.

Copy link

norraxx commented on server/matchmaker/pop_timer.py in 2c346d8 Aug 19, 2019

Sexy!

Askaholic added 2 commits Aug 19, 2019
@Askaholic Askaholic merged commit 0e27e2a into FAForever:develop Aug 30, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.04%) to 93.997%
Details
@Askaholic Askaholic deleted the Askaholic:smarter-queue-pop-times branch Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.