Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --dirty for fair pull #158

Merged
merged 12 commits into from
Nov 29, 2021
Merged

Fix --dirty for fair pull #158

merged 12 commits into from
Nov 29, 2021

Conversation

kzscisoft
Copy link
Collaborator

No description provided.

@kzscisoft kzscisoft changed the base branch from main to develop November 29, 2021 10:54
@sonarcloud
Copy link

sonarcloud bot commented Nov 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #158 (acc03dd) into develop (d847374) will increase coverage by 0.16%.
The diff coverage is 74.41%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #158      +/-   ##
===========================================
+ Coverage    73.06%   73.22%   +0.16%     
===========================================
  Files           24       24              
  Lines         3055     3089      +34     
===========================================
+ Hits          2232     2262      +30     
- Misses         823      827       +4     
Impacted Files Coverage Δ
fair/registry/requests.py 84.97% <ø> (ø)
fair/session.py 65.20% <71.05%> (+2.10%) ⬆️
fair/cli.py 54.92% <100.00%> (+0.14%) ⬆️
fair/run.py 78.16% <100.00%> (ø)
fair/user_config/__init__.py 79.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d847374...acc03dd. Read the comment docs.

@kzscisoft kzscisoft merged commit 74678cc into develop Nov 29, 2021
@kzscisoft kzscisoft deleted the 156-allow-dirty-run branch November 29, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-implement missing --dirty flag to allow running on uncommitted changes
1 participant