Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added data file download for pull from other registry #198

Merged
merged 13 commits into from
Jan 18, 2022

Conversation

kzscisoft
Copy link
Collaborator

Adds download of actual data files when running fair pull.

@kzscisoft kzscisoft added this to the Synchronisation milestone Jan 18, 2022
@kzscisoft kzscisoft added the enhancement New feature or request label Jan 18, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #198 (f814cd6) into develop (647e602) will increase coverage by 0.11%.
The diff coverage is 80.85%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #198      +/-   ##
===========================================
+ Coverage    74.20%   74.31%   +0.11%     
===========================================
  Files           24       25       +1     
  Lines         3512     3570      +58     
===========================================
+ Hits          2606     2653      +47     
- Misses         906      917      +11     
Impacted Files Coverage Δ
fair/session.py 63.24% <50.00%> (-0.19%) ⬇️
fair/registry/requests.py 81.92% <66.66%> (-1.41%) ⬇️
fair/registry/storage.py 74.53% <80.48%> (+1.98%) ⬆️
fair/registry/sync.py 86.80% <82.35%> (-4.02%) ⬇️
fair/register.py 79.16% <100.00%> (+0.94%) ⬆️
fair/registry/__init__.py 100.00% <100.00%> (ø)
fair/user_config/__init__.py 76.29% <100.00%> (+0.06%) ⬆️
fair/user_config/globbing.py 43.93% <100.00%> (ø)
fair/user_config/validation.py 94.00% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 647e602...f814cd6. Read the comment docs.

@kzscisoft kzscisoft merged commit b4ab6e3 into develop Jan 18, 2022
@kzscisoft kzscisoft deleted the kzscisoft/pull-rem-download branch January 18, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant