Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving to python 3 and further development #173

Closed
toubol opened this issue Apr 24, 2018 · 5 comments

Comments

@toubol
Copy link
Contributor

commented Apr 24, 2018

Hi,
I wanted to know how you see the future development of PyCorrFit, because I moved it to Python 3 to keep it up to date and to use it with my own configuration. But now that it works well, how can I open it to the community?
As far as I tested it, it is successfully running on windows 10, python 3.6, and the files are fully compatible with the actual stable release.

@paulmueller

This comment has been minimized.

Copy link
Member

commented Apr 24, 2018

Thanks for the question. I understood that you modified PyCorrFit to run under Python 3.6. Is that correct?
If you created a pull request, I would be very happy to merge it. Is it still compatible to Python 2.7? If not, then I would have to update the appveyor build pipeline as well.

I currently only have little time to further develop PyCorrFit. I am doing it in my free time.

@toubol

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2018

It is exactly that, it is now running under Python 3.6, but I also added some shortcuts and small changes just to get it more comfortable to my use.
I don't expect it to run under python 2.7.
I'll create the pool request soon, I just need to end commenting my changes.

@paulmueller

This comment has been minimized.

Copy link
Member

commented May 10, 2018

To not break the current workflow of other users, I have reverted/changed some of your modifications:

  • The behavior of text selection when the mouse enters a text field is an important feature that was requested earlier.
  • Autoclosing tools is not a desired behavior, because many users need the tools more than once in a fitting session. I added a preferences menu option for autoclosing.
  • For a detailed diff, please see 788e416
@paulmueller

This comment has been minimized.

Copy link
Member

commented May 10, 2018

TODO:

  • test-run all tools (function, autoclose)
  • test-run session saving and loading (also add tests)
  • test-run export options (current page menu, with/without latex)
  • fix appveyor builds (tests, pyinstaller, install on win10)
  • update documentation:
    - version numbers of dependencies
    - preferences menu choices
    - python3-wxgtk4.0 https://tracker.debian.org/pkg/wxpython4.0
    - instead, start over on readthedocs and let everyone know that the old docs are outdated.
  • rename ChangeLog.txt
  • check MANIFEST.in
  • remove all future imports and encoding declarations on top of all files
  • remove outdated wiki pages (or all of it, since it is not used): https://github.com/FCS-analysis/PyCorrFit/wiki (see #177)
  • add notice on how to cite pycorrfit
@toubol

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2018

Thank you for all your job. Even if I do not agree with all the changes, you better know the requested features.
It keeps running fine and this is the most important for me.
I will continue to send you my changes, and try to take part to the to-do list.

paulmueller added a commit that referenced this issue May 19, 2018

paulmueller added a commit that referenced this issue May 19, 2018

paulmueller added a commit that referenced this issue May 19, 2018

paulmueller added a commit that referenced this issue May 19, 2018

paulmueller added a commit that referenced this issue May 19, 2018

paulmueller added a commit that referenced this issue May 19, 2018

paulmueller added a commit that referenced this issue May 19, 2018

paulmueller added a commit that referenced this issue May 19, 2018

paulmueller added a commit that referenced this issue May 19, 2018

paulmueller added a commit that referenced this issue May 19, 2018

paulmueller added a commit that referenced this issue May 20, 2018

paulmueller added a commit that referenced this issue May 20, 2018

paulmueller added a commit that referenced this issue May 20, 2018

paulmueller added a commit that referenced this issue May 22, 2018

paulmueller added a commit that referenced this issue May 23, 2018

paulmueller added a commit that referenced this issue May 23, 2018

paulmueller added a commit that referenced this issue May 26, 2018

paulmueller added a commit that referenced this issue May 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.