New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file numbering #44

Closed
weidemann opened this Issue Oct 29, 2013 · 3 comments

Comments

Projects
None yet
2 participants
@weidemann
Collaborator

weidemann commented Oct 29, 2013

Reviewing release 0.8.0-1alpha

There are potentially 5 different numbers specifying a correlation data set: file name, run number, channel, as well as page number and internal identifier which are assigned during file loading. Currently file name, run, channels, and id appear in the "file/title" window which can be manually edited.

Suggestions:

  1. Reverse the order in which the string in the window "file/title" is generated to file name/run/channels/identifier, for example: file001 run001 AC1 data001. The last 7 letters could then be used as page name.
  2. Currently page numbers and data identifier are not the same. This may confuse when specifying data sets for post-processing, e.g.averaging. I think it is quite naturally to number data sets starting from 1, however if pages in PyCorrFit automatically start from 0, and this is not easy to change, I suggest to start the internal identifier "data000" also from zero.

Comment: To have the filename at the beginning is important for sorting the data according to name in other programs. Therefore it should be exportable.

@weidemann

This comment has been minimized.

Collaborator

weidemann commented Oct 31, 2013

I just saw that the internal identifier (id001) is not changed when loading one and the same data two times with different model assignment. Maybe this will create problems. In my opinion the cleanest way of numbering is to have a unique internal identifier; irrespective of whether this correlation function is modeled, imported, or duplicated. Ideally this identifier coincides with the page number. Loading the same data twice would allow the user to compare models and make decisions within the same session. After reviewing the data, inappropriate modeled data sets/pages could then simply be removed.

@paulmueller

This comment has been minimized.

Member

paulmueller commented Nov 10, 2013

Hi,
"id001" is an identifier for a particular curve in a file - it should be the same for different models. I think we can safely remove this identifier because we can identify each curve with run number and correlation type (AC/CC).
I will see if we can iterate the page numbers from 1 onwards.

paulmueller pushed a commit that referenced this issue Nov 21, 2013

Paul Müller
- Issue #44: Page number now always starts with 1
- Added link to PyCorrFit Wiki in Help menu

paulmueller pushed a commit that referenced this issue Dec 7, 2013

@paulmueller

This comment has been minimized.

Member

paulmueller commented Dec 7, 2013

Fixed in 0.8.1

@paulmueller paulmueller closed this Dec 7, 2013

paulmueller pushed a commit that referenced this issue Sep 30, 2015

Paul Müller
- Issue #44: Page number now always starts with 1
- Added link to PyCorrFit Wiki in Help menu


Former-commit-id: 0c31324f80424e9d0bfbdecacb1ad850eefcd920 [formerly ef7a9089a83f790b6a17faad9ad8bb9260fa87dd] [formerly 8f7f4c93f5e63e537933974541fc9c30cca8fc46 [formerly 4a1939dfed379a7a80b7e66866fdc035ee5538e0]] [formerly 77bb3364420d54e65dff680a9272ca57fc082fa9 [formerly 63eb9cc7fa42e452012f7446003429dfa6cd501f] [formerly 4a1939dfed379a7a80b7e66866fdc035ee5538e0 [formerly 672a6c7]]]
Former-commit-id: eb9f24dc7543333e49d9b1d59ec685ef43e2958a [formerly edec9282e94fd06c534a7eb82ae950fb2c2f053c] [formerly 99b4654aacb8ccbdf61fbb740fd6d5bd165f39a9 [formerly b80d717c7129194c076b728a4c7402dee7d01a9c]]
Former-commit-id: 99b4654aacb8ccbdf61fbb740fd6d5bd165f39a9
Former-commit-id: 22c08d065d301f859aaeac1e7caf3b924c4397c6

paulmueller pushed a commit that referenced this issue Sep 30, 2015

Paul Mueller
Fixed issue #44
Former-commit-id: 6f455af8456420b47ffac3e7021c5a3495c2ab45 [formerly a97dd6f5bbe6f762430c3260b22b2b39eeed0bed] [formerly 410442e41b4160a24b45d6c5f51461f9a482b1e8] [formerly ba0b521472fd41701fe59d7f31e919625b704c04 [formerly 3ecafe0a938650f07e80e2db0cef4ee556ff20d4] [formerly 410442e41b4160a24b45d6c5f51461f9a482b1e8 [formerly ff0d058]]]
Former-commit-id: d9415db0ad091b1d7a17d1c3c8c359f190f5f7b8 [formerly a5fa70ff1f92491f8eeaea8740dab1041a39d4bc] [formerly e0f47558fae004cd12d248cbbeb2f2946ad71c94 [formerly 17a60292d36a0a7b9770038cc3f36a653d201513]]
Former-commit-id: 38f8bb9a34b08a7da07afabbf3fc3a9edf3b737f [formerly e0f47558fae004cd12d248cbbeb2f2946ad71c94]
Former-commit-id: 8deadbac2c155fbb3db8765c255fce42a1ad7a96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment