New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamlining the "main window" #49

Closed
weidemann opened this Issue Nov 12, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@weidemann
Collaborator

weidemann commented Nov 12, 2013

Moin,

I think the organization of the main window still contains some adhoc decisions on names etc. I want to suggest a little rearrangement (0.8.0-1a):

The first box "Filename/title" could be renamed in "Data set". According to the way the data are organized in PyCorrFit it would be really useful to have both the "Filename/title" and the "Model name" (e.g. T-3D-3D) at the front of the main window. Many times I was not sure why something is not working and then it turned out that I looked at data with different model assignments. "Page info" is still a nice compilation but it is tedious to frequently search for the model in this text.

The Button "Set Range" better belongs to the current box "Fit parameters". Maybe it could be placed just at the right hand side of the button "Apply". It quite naturally improves the workflow. First one has to decide whether a parameter will be varied or fixed, then one may think about the range. (Note that all buttons have the first word a upper case and the following lower case: "Set range" not "Set Range").

I suggest renaming the four boxes of the main window in the following categories:

  1. Data set
  2. Model parameters
  3. Amplitude corrections
  4. Fitting options

Box 4. "Fitting options" would even make more sense, when the tool "Global fitting" could be incorporated there. The panel for "Global fitting" is first of all very small and the weighted fit menu of the tool is anyway a duplication from the main window.

paulmueller pushed a commit that referenced this issue Nov 14, 2013

@paulmueller

This comment has been minimized.

Member

paulmueller commented Nov 14, 2013

Global fitting is a very specialized tool. I would like to keep it away from the new user (in the tools menu).
I want to keep the fitting panels as simple as possible. Please start a separate discussion if you disagree.
-> fixed in 0.8.1

paulmueller pushed a commit that referenced this issue Sep 30, 2015

Paul Müller
Issue #49: Rework of the fitting panel.
Former-commit-id: 0769810245abd2c666c198a1aeab48da2c7c1cf5 [formerly d50a2e297cc53a4e775da61780ba4d146e7671ce] [formerly 3bd3b6aa43320c12dcf1ee340f9263fd4b1a042f [formerly eec05721b6ef7a454ee9df335e5a7b20f626eb7e]] [formerly 162daf11758535d4c9c9d202e2bfd0f13366af5e [formerly 2f4a1648351484e987bcc747a399e60d3d74ef85] [formerly eec05721b6ef7a454ee9df335e5a7b20f626eb7e [formerly 30a2c7c]]]
Former-commit-id: 55bf1a3a0e18aef03d9aae1c98bfb8fc655688ff [formerly 99e12e71c68f6b635306709e59e6f53903fbba24] [formerly e4209cc4709baa9c40f1a4a6668b909bda817ba8 [formerly 0631870eff787732a0d64e893e15ce6fe21ef287]]
Former-commit-id: 94503fbad6eda315c8acd8a6c62b46636f10143d [formerly e4209cc4709baa9c40f1a4a6668b909bda817ba8]
Former-commit-id: d98e1daf698e37ecc6af949c2d5b31cac11f22a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment