New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current page / Save correlation as image #54

Closed
weidemann opened this Issue Nov 15, 2013 · 6 comments

Comments

Projects
None yet
2 participants
@weidemann
Collaborator

weidemann commented Nov 15, 2013

Export works, curve and axes look nice.

However, in the 08.0-1alpha PyCorrFit version the legend is placed on top of the parameter values. Maybe the legend could be placed above the plot and the parameters inside the plot area. The same for exported trace view, where the legend could be placed above and the average intensities listed within the plot area.

The list of varied parameters is useful, I think the errors are less important. Instead I would like to see also the fixed parameters.

In my Windows 7 the "tau" is exported as a little square. Do I have the wrong font settings?

@paulmueller

This comment has been minimized.

Member

paulmueller commented Nov 15, 2013

The "tau" = square error is a unicode probelm in Windows. You need to install MiKTeX (http://miktex.org/) and go to "Preferences->Use Latex". It is important to install MiKTeX with automatic package download (there is a small checkbox somewhere during install). Creating the first plot then takes a while because some packages are downloaded in the background. Then everything should work fine.

@weidemann

This comment has been minimized.

Collaborator

weidemann commented Nov 15, 2013

fixed. Latex plot looks beautiful. Very nice.

In contrast to png, in the Latex version there are no errors listed. Ideally PyCorrFit would always generate a plot where all parameters of the box "Model Parameters" (old "Fit parameters") are listed from which the varied ones have an error of the type "x ± err" and the fixed ones have none "x".

This Latex stuff is publication quality, I am impressed.

@weidemann

This comment has been minimized.

Collaborator

weidemann commented Nov 15, 2013

A really small comment to the commands of the "Current page" menu:

It says "Save correlation as image"
and "Save trace view as image"

Precise would be "Save correlation function as image"
and "Save intensity trace as image"

Shorter but still consistent would be "Save correlation as image"
and "Save trace as image"

paulmueller pushed a commit that referenced this issue Nov 20, 2013

Paul Müller
- worked on issue #54
- fixed issue #56
@paulmueller

This comment has been minimized.

Member

paulmueller commented Nov 24, 2013

The positions of legend and parameters will always annoy someone. If you export the images as .svg then you can shift them around to your liking in Illustrator or Inkscape. Hope this helps for the time being.

@paulmueller

This comment has been minimized.

Member

paulmueller commented Dec 9, 2013

We agree on:

  • correlation:
    • no errors from the fit in the plot
    • all parameters in the plot
  • trace:
    • show average countrate in plot
  • (show legend above plot)

paulmueller pushed a commit that referenced this issue Feb 4, 2014

paulmueller pushed a commit that referenced this issue Feb 22, 2014

Paul Müller
Issue #54:
-average now in legend of trace
-parameters in correlation plot now with significant digits
@paulmueller

This comment has been minimized.

Member

paulmueller commented Feb 22, 2014

fixed in 0.8.3

paulmueller pushed a commit that referenced this issue Sep 30, 2015

Paul Müller
- worked on issue #54
- fixed issue #56


Former-commit-id: 0637ff590cc0d722fe44d4a5e4fa81179efe7fb6 [formerly 6a0fe389fab71f2868b3098dcc6e81d8b497d058] [formerly da82a731ef83bdc1ab14b3355929dee313d091c7] [formerly adcf9650cb8f74042e9bc3e11a79e787540c399d [formerly f5216d003e2f89cdc5b8b63e1341b5a64f2dd36a] [formerly da82a731ef83bdc1ab14b3355929dee313d091c7 [formerly a618391]]]
Former-commit-id: 250f13fa1e2a0ffdd0bb923178aa6ed06f8c4b9a [formerly 01faae3f8d9f8662683a2cb1e99a775ae9349603] [formerly 06a8e1e3f446f042cde9629332610cbe9b122d12 [formerly 344a4c63634ed402fb29b429049be1b0e93d85ae]]
Former-commit-id: 06a8e1e3f446f042cde9629332610cbe9b122d12
Former-commit-id: 7d911b25d06e076292e8aadf39cbc2a1baed6763

paulmueller pushed a commit that referenced this issue Sep 30, 2015

Paul Müller
Issue #54: Removed Deltas from plot and added all parameters
Former-commit-id: d92f539a8064443c3aa88e0f3542aa25a73f108e [formerly 70a16ecc2ca4d45bc2e359770fe5b8089f794be4] [formerly 4384ad2bc730913d0de07be3ffdefd033072c550 [formerly 3bcf612c822850503eae4400fde2a163233dbb79]] [formerly 8b91d04e738d248fc25acd657db3f567ed8bf398 [formerly bd0f4b3b5680a08afe2d5c856cb9e33ea4c523e0] [formerly 0078865181b9a9bd12503801bb4b818745d5160d [formerly 8048654]]]
Former-commit-id: 59f03d543c478579a73fd844308b9b358401c2ea [formerly ab1f7c2b33daa9b22b1056af5310d187f70f78a6] [formerly 5b2188a950451e4c4eb864f2c2c68b85be9682c2 [formerly 71b6644868a827e1e4f37a03f74ee9b9636cf430]]
Former-commit-id: 8f7974c4e916732ec878e6453bc86c890d374a73 [formerly fe7460fdc78a5a63a946dd5b9f5e629beb8350da]
Former-commit-id: 47383a35091ea05843daad6602f39239985210cd

paulmueller pushed a commit that referenced this issue Sep 30, 2015

Paul Müller
Issue #54: eye-candy
Former-commit-id: 95b2cc0a067d5317a5a8aa8a07e567cafcfa2989 [formerly e7597c43c3b9a5d8a114bf933faf3dc2352fe5d8] [formerly 2f1d480d03b315c53adb66465574e69aa09f2ca4 [formerly 62104af3786b81f5b1e5b28b0b9ec03d4bc52523]] [formerly 43b8bcece2c5f65a6a8a0d22385b45d974da6e4d [formerly bc95198e6ff5fe5bded151daa23e0f1cd1fe9720] [formerly d2c564ca6f5db650511a8803221f47ab8464b236 [formerly c5e642d]]]
Former-commit-id: ed8baeefe2b97f8438edf337d35220d10698b77a [formerly 6102ea80fd78d6f83b469e90189642b356d3897d] [formerly 9f5d38594a9101e334105643d03cd8f8d2cbaca5 [formerly 71bdaa5d44e13b06e8e850edaad55ebd23174342]]
Former-commit-id: a8c7852e0cc3521e7537e2333bd3641dbe2bfc12 [formerly 033c8c600fd22cd4f86e70f397b70994a25f8f99]
Former-commit-id: d6549863988a8b75c30fe21fff201e0aa99bf6f1

paulmueller pushed a commit that referenced this issue Sep 30, 2015

Paul Müller
Issue #54:
-average now in legend of trace
-parameters in correlation plot now with significant digits


Former-commit-id: b43c00dca59620bc180769d8377aa8f779cdf44d [formerly 8465b501704eaccae50267f0c7324130cf587844] [formerly bebb37ac9c29e918cbcc541a6b0621cbcc7c1210 [formerly 9c614d26a7ae1d3b213ea9cb50dbb06c6fedf93b]] [formerly 812d910b85a1344e2038484c77cd67768c588d5d [formerly e9181b0ea1249729206b273427141cd0e07cefe5] [formerly ddca4370f4d407e543156579830b0f91a07a15cf [formerly afd3af2]]]
Former-commit-id: 679c93f6afd4b29a68e3a6a39cc5980f39424e90 [formerly 0e02e661bc9dc74f664cfc04ee6f789bab009dd4] [formerly 60b6370442edc2d5e9e18187efe94ebce474ca40 [formerly e28b954ce215f18aacd3e56f1276a638ae7de32d]]
Former-commit-id: 7710b165c38c9decf9cc6812d7ed377383fa7794 [formerly d31965b5bb8c8934b54733e0bc3bcc30a48c5312]
Former-commit-id: 39e20cec14478b497a1c5041c3fa22e4b774d69d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment