New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool Average data #58

Closed
weidemann opened this Issue Nov 22, 2013 · 5 comments

Comments

Projects
None yet
2 participants
@weidemann
Collaborator

weidemann commented Nov 22, 2013

The issue refers to vs 0.8.0-1alpha

In this version the different runs are not recognized as different curves and therefore the most frequent application, averaging of runs, cannot be performed. Might already be solved for changed file numbering in vs 0.8.2.

It is also not true that the program discriminates AC from CC although this is stated in the text of this panel. I could happily average AC1 with AC2, CC12, and CC21. Which does not bother, because the channels are anyway nicely sorted in the Overlay tool. Since it is convenient to select curves there, the channel distinction for the average tool could be ignored.

The fact that this tool allows to assign new models when creating a new page containing the average correlation curve, would in principle allow to assign new models to single, duplicated datasets in the same session. However, it cannot yet be done with single curves. A warning says that at least 2 different curves must be selected. Is there an inherent necessity for this constraint? One could simple give a new filename/title: filename run001 AC1 data001b.

paulmueller pushed a commit that referenced this issue Nov 24, 2013

Paul Müller
Distribution with .egg files should now work.
- Edited possible locations for ChangeLog and Documentation
- Edited chooseimport, there might have been a bug related to issue #58
- Added added location in bin/pycorrfit for distribution with .egg files
@paulmueller

This comment has been minimized.

Member

paulmueller commented Nov 24, 2013

In the current development version:

  • Averaging works
  • Averaging between AC and CC is not permitted - This is necessary, because we do not know what to do with the two traces.
@paulmueller

This comment has been minimized.

Member

paulmueller commented Nov 24, 2013

fixed in 0.8.1

@paulmueller

This comment has been minimized.

Member

paulmueller commented Dec 9, 2013

Averaging when the single page is the first page (number 1) does not work.

@paulmueller paulmueller reopened this Dec 9, 2013

@paulmueller

This comment has been minimized.

Member

paulmueller commented Dec 9, 2013

Selecting an average and averaging only page 1 does not work.

@paulmueller

This comment has been minimized.

Member

paulmueller commented Dec 13, 2013

(not fixed in beta)
fixed in 0.8.1

paulmueller pushed a commit that referenced this issue Sep 30, 2015

Paul Müller
Distribution with .egg files should now work.
- Edited possible locations for ChangeLog and Documentation
- Edited chooseimport, there might have been a bug related to issue #58
- Added added location in bin/pycorrfit for distribution with .egg files


Former-commit-id: 1b32287afaddc76856966a5c41754f6103209159 [formerly b265cd40b3257caac859a47ee0dda31b6b23bd38] [formerly 4b2b3b714ae226c63bbe2569ed937a9208194849] [formerly d83f75630613f8451ac343e345b4928ea583e5d9 [formerly 1fd7d24cf9146fa57bea60e9b435ddb8f0ac6ad9] [formerly 4b2b3b714ae226c63bbe2569ed937a9208194849 [formerly f555592]]]
Former-commit-id: a9b880cfb7d4bb4e1bd38b1d8468f87ad5ed0571 [formerly 71e8c94906a57791ad4347cc324fd82560821f88] [formerly 4339d26f16597f7dbcacb9db22bf8f0de87ae041 [formerly 6e1e65567bd878ca20cb3354cb91e3c00b4f35d2]]
Former-commit-id: 4339d26f16597f7dbcacb9db22bf8f0de87ae041
Former-commit-id: 4c6534c1cb85e7fbe8593710f20e520ce42cbc2e

paulmueller pushed a commit that referenced this issue Sep 30, 2015

Paul Müller
Averaging of single pages now works (#58)
Former-commit-id: 6bda2d692ebcb473db287c601f6f0822fdcc513d [formerly 746d2d2d5b7917dd1af4e75f168d19d23c32d006] [formerly 0da754fd460b19cf7be24f24c73e32d229b2ced4] [formerly d7b5d71a0e88e2893538d7367129dc3d5b80bcca [formerly 7fc7a3a00c83126b2859f55e30f8dde273c422c0] [formerly 0da754fd460b19cf7be24f24c73e32d229b2ced4 [formerly ecba4d4]]]
Former-commit-id: 824234ee5b012a0f16ebe44855894febb54609d1 [formerly d4ebda157375a7fcb4ba5101051dde9a0355a6f1] [formerly d6f7bebbde4af0e43ef835a37d4a4bac37dd19f6 [formerly 28b643bef8fe7174f64f95364adaf5655e0bb2e6]]
Former-commit-id: 974b7562702cda36a2f5965488c65f34a8c2c1ac [formerly d6f7bebbde4af0e43ef835a37d4a4bac37dd19f6]
Former-commit-id: 2937e2ceb62750bd867cf14667ef57dc0f3428ac

paulmueller pushed a commit that referenced this issue Sep 30, 2015

Paul Mueller
fixed #58. Reference page is now the first page - not the current page.
Former-commit-id: db7f7584d9763b574b9e7761b26a6e20b54de04e [formerly df0b637e84ec4d64776571f570235df02521d5e0] [formerly 120c9e6e903c1bdbd5af9ca1363924f16c1c35a4 [formerly 9392fa155b25c6f3aa07923707735a7c169f728c]] [formerly d81155ee8952c8a726f02cd736285c9e2761aad0 [formerly 0eb57c97a5a333bf4498af13a7e0bf4c907478ac] [formerly 9392fa155b25c6f3aa07923707735a7c169f728c [formerly ddfd6a0]]]
Former-commit-id: 4d2e6c831ff327f19ca2029105948754ff8e185b [formerly 9afb7a93ebb844805b6409acc15c58f6f192fd7a] [formerly 6e0a2e734bb8496a558771a10350208d4ef62f23 [formerly 7b301af265a5b500cf7da6db10158e3a81e8e2a1]]
Former-commit-id: 6e0a2e734bb8496a558771a10350208d4ef62f23
Former-commit-id: 26e108e42c35ddf9c1da0448db54a6320a526bc4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment