New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyscanfcs tests fail on some architectures #17

Closed
mestia opened this Issue Nov 23, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@mestia
Copy link

mestia commented Nov 23, 2018

pyscanfcs tests fail on few architectures such as mips, ppc64, and s390.
My guess is that the failure is related to endianness - they all are big-endian as far as I see.
Any hint how to fix that?
Here is the build-log on mips

Thank you.
Alex

paulmueller added a commit that referenced this issue Nov 24, 2018

@paulmueller

This comment has been minimized.

Copy link
Member

paulmueller commented Nov 24, 2018

Could you please try again with the latest commit? If it fails again with an explicit endinness-error, I have another idea how to fix it.

@paulmueller paulmueller added the bug label Nov 24, 2018

@mestia

This comment has been minimized.

Copy link

mestia commented Nov 28, 2018

Now it fails with:

>   Data = np.fromfile(File, dtype="<u2", count=-1)
E   ValueError: Little-endian buffer not supported on big-endian compiler

buildlog on mips

paulmueller added a commit that referenced this issue Nov 28, 2018

@paulmueller

This comment has been minimized.

Copy link
Member

paulmueller commented Nov 28, 2018

I think this was caused by the fact that the code for opening these .dat file was (unnecessarily) part of a Cython module. I refactored the code (see commit above). Please try again.

@mestia

This comment has been minimized.

Copy link

mestia commented Dec 5, 2018

Tests pass now. I've made the package from d295b59 and it works. build on mips.

@mestia mestia closed this Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment