Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API for getting all client items #59

Open
wants to merge 2 commits into
base: master
from

Conversation

3 participants
@CrazyHackGUT
Copy link
Contributor

commented Jul 1, 2019

This PR implements new API method: Shop_GetClientItems(). This method accepts client index on server, and returns the array with item ids which player have.

Method documented in include-file.

@CrazyHackGUT CrazyHackGUT requested review from R1KO and TiBarification Jul 1, 2019

@CrazyHackGUT CrazyHackGUT changed the title Implemented Shop_GetClientItems() API method API for getting all client items Jul 1, 2019

@TiBarification
Copy link
Contributor

left a comment

It is good enough if you want to get items once, but each time you will use this function, it may cause shop to work heavily. I mean it can get a huge amount of data per each user. The more items shop have, the bigger keyvalue is.

So i recommend to use this function rarely. Also in a fact that when you dump this pointer and get information, and you buy something, you will have outdated info in a dump.

@TiBarification TiBarification self-requested a review Jul 2, 2019

@CrazyHackGUT

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

each time you will use this function, it may cause shop to work heavily

We can leave this comment in notes in include.

Also, need test this native. I don't tested yet.
I wrote simple plugin for test. Download here. Adds command sm_shop_dumpmyitems for this purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.