Add divergence conforming discontinuous Galerkin demo for the Navier-Stokes equations #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If anyone feels this would be better kept outside the main repository, it could be added to the FEniCSx tutorial instead if @jorgensd is happy |
nate-sime
reviewed
Oct 3, 2022
nate-sime
reviewed
Oct 3, 2022
python/demo/demo_navier_stokes.py
Outdated
| # $\Omega \subset \mathbb{R}^d$, $d \in \{2, 3\}$, and time interval | ||
| # $(0, \infty)$, given by | ||
| # $$ | ||
| # \partial_t u - \nu \Delta u + (u \cdot \nabla)u + \nabla p = f |
There was a problem hiding this comment.
Does \nu actually get used in the discretisation?
There was a problem hiding this comment.
The discretisation uses the dimensionless form, where \nu is incorporated into the Reynolds number. I'll make this clearer
nate-sime
reviewed
Oct 3, 2022
nate-sime
reviewed
Oct 3, 2022
nate-sime
reviewed
Oct 3, 2022
…inx into jpdean/div_con_navier_stokes
UFL doesn't properly support DG-type operators with complex.
…inx into jpdean/div_con_navier_stokes
garth-wells
reviewed
Jan 4, 2023
garth-wells
reviewed
Jan 4, 2023
Need to figure out how to include extra latex packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a divergence conforming discontinuous Galerkin demo for the Navier-Stokes equations.
It demonstrates:
As far as I'm aware, none of the other demos demonstrate the above functionality.
I still need to so some tidying. Any feedback would be much appreciated.