Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review ietf cellar ffv1 02 secdir early xia 2018 06 01 #116

Conversation

Projects
None yet
3 participants
@dericed
Copy link
Contributor

commented Jun 1, 2018

addresses many of the comments in https://datatracker.ietf.org/doc/review-ietf-cellar-ffv1-02-secdir-early-xia-2018-06-01/.

#115 should be resolved before this is merged.

@@ -476,7 +474,7 @@ RFC:```
RFC:j_{0} = 2
RFC:```
#### Range non binary values
#### Range Non Binary Values

This comment has been minimized.

Copy link
@retokromer

retokromer Jun 1, 2018

Contributor

I am not an English speaker: Non Binary or Non-Binary?

This comment has been minimized.

Copy link
@dericed

dericed Jun 27, 2018

Author Contributor

IIRC hyphens present in section headers break the inter-sectional linking as the document is processed through mmark and xml2rfc.

This comment has been minimized.

Copy link
@retokromer

retokromer Jun 27, 2018

Contributor

Thank you for the explanation, @dericed!

@retokromer
Copy link
Contributor

left a comment

One question, otherwise LGTM.

@michaelni michaelni merged commit 70b689a into FFmpeg:master Jun 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.