Permalink
Browse files

configure: Don't disable SSA Optimizer on MSVC v19.00.24218+.

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
  • Loading branch information...
kasper93 authored and Michael Niedermayer committed Jan 12, 2017
1 parent bdbbb8f commit 2064a3b8dfd80018bb01ea30d0d7dbc5d62ddc5c
Showing with 3 additions and 3 deletions.
  1. +3 −3 configure
View
@@ -6320,9 +6320,9 @@ EOF
check_func strtoll || add_cflags -Dstrtoll=_strtoi64
check_func strtoull || add_cflags -Dstrtoull=_strtoui64
# the new SSA optimzer in VS2015 U3 is mis-optimizing some parts of the code
# this flag should be re-checked on newer compiler releases and put under a
# version check once its fixed
check_cflags -d2SSAOptimizer-
# Issue has been fixed in MSVC v19.00.24218.
check_cpp_condition windows.h "_MSC_FULL_VER >= 190024218" ||
check_cflags -d2SSAOptimizer-
fi
for pfx in "" host_; do

2 comments on commit 2064a3b

@v0lt

This comment has been minimized.

Show comment
Hide comment
@v0lt

v0lt Jul 24, 2017

Where can I download this compiler update?

v0lt replied Jul 24, 2017

Where can I download this compiler update?

@kasper93

This comment has been minimized.

Show comment
Hide comment
@kasper93

kasper93 Jul 24, 2017

Contributor

Hi @v0lt, long time no see.

VS2017 has newer MSVC bundled and it is periodically updated. So it is fixed there.

VS2015 as for as my install goes still have 19.00.24215.1 bundled. But they provided this hotfix package https://support.microsoft.com/en-us/kb/3207317 in my bug report about this bug. For reference https://connect.microsoft.com/VisualStudio/feedback/details/2890170

Also Microsoft releases preview version of their compiler every day. https://blogs.msdn.microsoft.com/vcblog/2016/04/26/stay-up-to-date-with-the-visual-c-tools-on-nuget/ But I wouldn't use it unless you are doing some troubleshooting. On the other hand probably this is the same thing they release as stable, every so often. So if they have good testing env, it should be fine for personal use.

Contributor

kasper93 replied Jul 24, 2017

Hi @v0lt, long time no see.

VS2017 has newer MSVC bundled and it is periodically updated. So it is fixed there.

VS2015 as for as my install goes still have 19.00.24215.1 bundled. But they provided this hotfix package https://support.microsoft.com/en-us/kb/3207317 in my bug report about this bug. For reference https://connect.microsoft.com/VisualStudio/feedback/details/2890170

Also Microsoft releases preview version of their compiler every day. https://blogs.msdn.microsoft.com/vcblog/2016/04/26/stay-up-to-date-with-the-visual-c-tools-on-nuget/ But I wouldn't use it unless you are doing some troubleshooting. On the other hand probably this is the same thing they release as stable, every so often. So if they have good testing env, it should be fine for personal use.

Please sign in to comment.