Release/2.7 #201
Closed
Release/2.7 #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No testcase known Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit ac0ba6f) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
No testcase known Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 45f3d4e) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 781efd0) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
…long loops Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit ee155c1) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 6701c92) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
…absence of errors Fixes assertion failure Fixes: 56dcafde14a8397161bb61a16c511179/signal_sigabrt_7ffff6ac8cc9_686_cov_1897408623_microsoft_new_way_to_shove_mpeg2_in_asf.dvr_ms Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit b54e03c) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Fixes out of array access Fixes: 87196d8bbc633629fc9dd851fce73e70/asan_heap-oob_26f6853_862_cov_585961513_sonic3dblast_intro-partial.avi Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 63fb5a6) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Fixes undefined behavior Fixes: 1700002963a49da13542e0726b7bb758/unknown_unknown_292_658_cov_2141972066_m1.mxg Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit c7c207a) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Fixes: unknown_unknown_19e_414_cov_764838672_bellhamlam.mov Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit d1bdaf3) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 733511f) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
This macro avoids the undefined corner case with the *_MIN values Previous version Reviewed-by: Ganesh Ajjanagadde <gajjanag@mit.edu> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit d6cd614) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Fixes: unknown_unknown_19e_414_cov_764838672_bellhamlam.mov Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 053e80f) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Fixes CID1322333 Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 32f5395) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Fixes CID1322316 Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit cbd3cd8) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Fixes: CID1322319 Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit f1593e4) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Fixes: CID1322313 Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit a51d424) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Fixes CID1322351 Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 71ec8e1) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit fb04666) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
long may not be 64 bit on all platforms; so labs on int64_t is unsafe. This fixes a warning reported in: http://fate.ffmpeg.org/log.cgi?time=20150905071512&log=compile&slot=i386-darwin-clang-polly-3.7 Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit d74123d) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 055e56e) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
…eam. Not requiring this can end up producing hilariously broken files together with -c:s copy (e.g. a webvtt file containing binary subtitle data). Signed-off-by: Simon Thelen <ffmpeg-dev@c-14.de> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit b842326) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
This should fix warning reported by fate client: http://fate.ffmpeg.org/report.cgi?time=20150917113121&slot=x86_32-linux-gnu-gcc-4.5.1-have_6regs. Untested. Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 63cdb6e) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Fixes hang.nut Found-by: Paul B Mahol <onemda@gmail.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit b2955b6) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Forwards the error code, avoids potential integer overflow Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 10bbf6c) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Fixes: invalid_read.nut Found-by: Paul B Mahol <onemda@gmail.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 2d221d9) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Fixes crash Fixes: flicker-1.scout3d21443372922.28.m4a Found-by: Dale Curtis <dalecurtis@google.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 1b82b93) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
This fixes access to Grandstream cameras, which return 401 to ffmpeg otherwise. VLC sends Authorization: header with spaces between parameters, and it is known to work with Grandstream devices and broad range of other HTTP and RTSP servers, so author considers switching to such behaviour safe. Just for record - RFC 2617 (HTTP Auth) does not specify the need in spaces, so this is not a bug of FFmpeg. Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit fdb3283) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
… header decoding fails for other reasons Fixes Ticket4931 Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 4c2d4e8) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Fixes deadlock Fixes Ticket4932 Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 5063a18) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
This ensures that they are always set to valid values Fixes Ticket4939 Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit a878dfa) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 3617e69) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Found-by: jamrial Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 554f6e9) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
RTCP synchronization packet was broken since commit in ffmpeg version > 2.8.3 (commit: e04b039) Since this commit (2e814d0) "rtpenc: Simplify code by introducing a macro for rescaling NTP timestamps", NTP_TO_RTP_FORMAT uses av_rescale_rnd() function to add the data to the packet. This causes an overflow in the av_rescale_rnd() function and it will return INT64_MIN. Causing the NTP stamp in the RTCP packet to have an invalid value. Github: Closes #182 Reverting commit '2e814d0329aded98c811d0502839618f08642685' solves the problem. (cherry picked from commit 1109ed7) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
…ascending delay Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit de1de49) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
This is safer, as a selected demuxer could still mean that it was auto-detected by a user application Reviewed-previously-by: Nicolas George <george@nsup.org> Reviewed-previously-by: Andreas Cadhalpun <andreas.cadhalpun@googlemail.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 689211d) Conflicts: libavformat/concatdec.c
…sing Trying to make heads and tails out of DTS 6.1 I can across this typo. I also noticed that this wiki page is incorrect or misleading, the channel order for 6.1 given does not match the source code. At the least it should be clarified that the layout given does not apply to DTS. https://trac.ffmpeg.org/wiki/AudioChannelManipulation Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 73d1398) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
… entropy pool This should theoretically improve the randomness slightly Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 2540d88) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 0d097a8) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Rename luma table to delta table and change how it is used. CC: libav-stable@libav.org Signed-off-by: Vittorio Giovara <vittorio.giovara@gmail.com> Signed-off-by: Diego Biurrun <diego@biurrun.de> (cherry picked from commit f8c34f4) (cherry picked from commit 73f3c8f) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Fixes Ticket5345 Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 50ef736) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
…stored Fixes Ticket5244 Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 068026b) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Original mail and my own followup on ffmpeg-user earlier today: I have a device sending out a MJPEG/RTP stream on a low quality setting. Decoding and displaying the video with libavformat results in a washed out, low contrast, greyish image. Playing the same stream with VLC results in proper color representation. Screenshots for comparison: http://zevv.nl/div/libav/shot-ffplay.jpg http://zevv.nl/div/libav/shot-vlc.jpg A pcap capture of a few seconds of video and SDP file for playing the stream are available at http://zevv.nl/div/libav/mjpeg.pcap http://zevv.nl/div/libav/mjpeg.sdp I believe the problem might be in the calculation of the quantization tables in the function create_default_qtables(), the attached patch solves the issue for me. The problem is that the argument 'q' is of the type uint8_t. According to the JPEG standard, if 1 <= q <= 50, the scale factor 'S' should be 5000 / Q. Because the create_default_qtables() reuses the variable 'q' to store the result of this calculation, for small values of q < 19, q wil subsequently overflow and give wrong results in the calculated quantization tables. The patch below uses a new variable 'S' (same name as in RFC2435) with the proper range to store the result of the division. Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit e3e6a2c) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
…efcounted_frames is set Reviewed-by: maintainer Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 0cd9ff4) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
http://ghostscript.com/~tor/gs-browse/gs/openjpeg/libopenjpeg/t1.c Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit b6b4b0a) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Currently, if the movie source filter is used and a seek_point is
specified on a file that has a negative start time, ffmpeg will fail.
An easy way to reproduce this is as follows:
$ ffmpeg -vsync passthrough -filter_complex 'color=d=10,setpts=PTS-1/TB' test.mp4
$ ffmpeg -filter_complex 'movie=filename=test.mp4:seek_point=2' -f null -
The problem is caused by checking for int64_t overflow the wrong way.
In general, to check whether a + b overflows, it is not enough to do:
a > INT64_MAX - b
because b might be negative; the correct way is:
b > 0 && > a > INT64_MAX - b
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit c1f9734)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
…de packet crossing corner case Fixes Ticket 5438 Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 8e26bdd) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Sometimes video fails to decode if H.264 configuration changes mid stream. The reason is that configuration parser assumes that nal_ref_idc is equal to 11b while actually some codecs but 01b there. The H.264 spec is somewhat vague about this but it looks like it allows any non-zero nal_ref_idc for sps/pps. Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 3a72760) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Fixes out of array read Fixes: mozilla bug 1266129 Found-by: Tyson Smith Tested-by: Tyson Smith Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 9f36ea5) Conflicts: libavcodec/avpacket.c
… silence Signed-off-by: Paul B Mahol <onemda@gmail.com> (cherry picked from commit 9149e9c) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Paul B Mahol <onemda@gmail.com> (cherry picked from commit 38797a8) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Fixes segfault Fixes Ticket5347 Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 2e67a99) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Fixes Ticket5319 Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 9ac154d) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Functionality used before didn't widen the values from limited to full range. Additionally, now the decoder uses BT.709 where it should be used according to the video resolution. Default for not yet set colorimetry is BT.709 due to most observed HDMV content being HD. BT.709 coefficients were gathered from the first two parts of BT.709 to BT.2020 conversion guide in ARIB STD-B62 (Pt. 1, Chapter 6.2.2). They were additionally confirmed by manually calculating values. Fixes #4637 (cherry picked from commit 9779b62) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Fixes assertion failure Fixes Ticket5394 Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 005c61c) Conflicts: libavcodec/ttaenc.c
Fixes crash Fixes Ticket5412 Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 78baa45) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Contributor
|
please submit patch requests to the ffmpeg-devel mailing list instead of as github pull request, thanks! |
BtbN
pushed a commit
that referenced
this pull request
Mar 20, 2024
The second part of this condition is intended to check whether the current quantisation group is in the first CTU column of the current tile. The issue is that ctb_to_col_bd gives the x-ordinate of the first column of the current tile *in CTUs*, while xQg gives the x-ordinate of the quantisation group *in samples*. Rectify this by shifting xQg by ctb_log2_size to get xQg in CTUs before comparing. Fixes FFVVC issues #201 and #203.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.