Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avdecode/avfoundation: use AudioConverter & fix thread concurrency #374

Closed
wants to merge 1 commit into from

Conversation

toots
Copy link
Contributor

@toots toots commented Nov 18, 2021

This PR adds one feature and fixes one issue:

New feature

This PR adds support for PCM format conversion using AudioConverter. This extends audio support to unpacked inputs and also cleans up conversion from non-interleaved to interleaved format.

This addresses this ticket: https://trac.ffmpeg.org/ticket/9502

Fix thread concurrency

The thread model in the avfoundation runs two threads concurrently, one that pulls data out of the input devices and one that pulls data into the FFmpeg stack. There was a lock preventing concurrent access to captured data preventing concurrent access but this was missing a condition, resulting in dropped frames. This PR adds a it as well.

@retokromer
Copy link
Contributor

Please consider #153

@toots toots force-pushed the avdevice-avfoundation-cleanup branch from ba8006e to bd30d55 Compare November 18, 2021 17:05
@BtbN
Copy link
Member

BtbN commented Nov 18, 2021

Patches should be submitted to the ffmpeg-devel mailing list using git format-patch or git send-email. Github pull requests should be avoided because they are not part of our review process and will be ignored.

See https://ffmpeg.org/developer.html#Contributing for more information.

@BtbN BtbN closed this Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants