Avdecode/avfoundation: use AudioConverter & fix thread concurrency #374
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds one feature and fixes one issue:
New feature
This PR adds support for PCM format conversion using
AudioConverter. This extends audio support to unpacked inputs and also cleans up conversion from non-interleaved to interleaved format.This addresses this ticket: https://trac.ffmpeg.org/ticket/9502
Fix thread concurrency
The thread model in the avfoundation runs two threads concurrently, one that pulls data out of the input devices and one that pulls data into the FFmpeg stack. There was a lock preventing concurrent access to captured data preventing concurrent access but this was missing a condition, resulting in dropped frames. This PR adds a it as well.