Skip to content

Convert PHP serialized arrays to json & fix UTF-8 languages detection #6

Merged
merged 3 commits into from Mar 1, 2013

2 participants

@RuslanZavacky
Collaborator

As I've tried to detect russian language, it failed. Removed serialized arrays and also removed _next_char PHP based implementation, as its not needed in JS.
Also added string cleaning before processing.

More work to be done :)

I've fixed tests in .js file only, as I do not see any need in CS here..

@RuslanZavacky
Collaborator

Hmm, I've changed algorithm a bit, Travis build are failing, I'll into it later

@FGRibreau
Owner

Hello!

Thanks! I'll merge this when all test pass (you can update the tests accordingly).

@RuslanZavacky
Collaborator

How about removing .coffee files? As for now project is on JS, and this files for tests just add complexity :) I think I'll support this project and will try to improve some parts, as they are from port from PHP and some things just could be done better )

@FGRibreau
Owner

Thanks!

Yes, please remove .coffee files, that's fine with me (at that time I was testing coffee capabilities).

@FGRibreau FGRibreau merged commit fb907f5 into FGRibreau:master Mar 1, 2013

1 check passed

Details default The Travis build passed
@FGRibreau
Owner

I just added you as a contributor on github, I will wait a little before giving you the npm right as well. Is that okay with you?

@RuslanZavacky
Collaborator

Hey, yes sure, this is nice :) I will do my best to improve it and I hope this becomes useful to more people :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.