Fix for standalone msg variables inside agent python #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and associated new test. Closes #1110
Robadob
force-pushed
the
bugfix_agentpython_standalone_msg
branch
from
e91f0ff
to
e603d0d
Compare
Robadob
commented
Sep 21, 2023
| @@ -752,7 +770,7 @@ def _FunctionDef(self, t): | |||
| # check for return annotation type | |||
| if not isinstance(t.returns, ast.Name): | |||
| self.RaiseError(t, "Agent function conditions return type must be 'bool'") | |||
| if t.returns.id is not 'bool': | |||
| if t.returns.id != 'bool': | |||
There was a problem hiding this comment.
I got a weird warning about this, so thought best to fix. Unrelated to PR.
Robadob
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change:
CodeGen::_Assign()Added a detection when a variable is created via<inputmsg>.at(), adding the variables identifier toself._standalone_message_var.CodeGen::dispatchMemberFunction()Check whether the variable can be found insideself._standalone_message_var, if so treat it similar to an input message iterator.Note:
Potential issue that these variables are never removed from the list, e.g. if they should be going out of scope.
Closes #1110