Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout for simulation #75

Open
sunilshetye opened this Issue Nov 26, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@sunilshetye
Copy link
Collaborator

sunilshetye commented Nov 26, 2018

Add SCILAB_INSTANCE_TIMEOUT_INTERVAL to config.py. Add start time when command is run. Add a timeout = start time + SCILAB_INSTANCE_TIMEOUT_INTERVAL to the scilab-adv-cli instance. At the end of the timeout, kill the scilab-adv-cli instance and return error.

When a user clicks on simulate in the browser, a scilab-adv-cli instance starts. If the user does not click on Stop, this instance can continue forever. This happens with diagrams having specific type of blocks. Ensure that simulation stops cleanly after reaching the timeout.

At present, the value of SCILAB_INSTANCE_TIMEOUT_INTERVAL will be 3 minutes.

Later, we can add support for timeout based on specific blocks in the diagram.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.