fix: support wildcard accept-encoding negotiation#194
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
VikramAditya33
left a comment
There was a problem hiding this comment.
LGTM, Thank you and well done. Just one thing is consider adding a test for *;q=0 (wildcard explicitly rejected) though this isn't strictly necessary since wildcardQuality > 0 guards against it, but it documents the behavior for future readers.
Also comment under the issue to get assigned
Summary
Accept-Encoding: *into supported compression encodings during negotiationgzip;q=0) excluded from wildcard expansionCloses #193
Verification
npm test -- --runInBand src/http/handlers/compression/compression-handler.spec.tsnpm run lintnpm run buildSummary by CodeRabbit
Release Notes
*) Accept-Encoding preferences, properly expanding them to supported compression methods while respecting explicitly rejected encodings.