Skip to content
Permalink
Browse files

lib: Remove zlog_warn from some places in buffer.c

zlog_warn was being used to inform user of impossible situations
or for normal operations.  Remove these from the code.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
  • Loading branch information...
donaldsharp committed Aug 16, 2018
1 parent 807ed4e commit 07436e2a526ec10355eb8aa7efc6063d8eb5eeb5
Showing with 3 additions and 15 deletions.
  1. +3 −15 lib/buffer.c
@@ -274,19 +274,12 @@ buffer_status_t buffer_flush_window(struct buffer *b, int fd, int width,
if (!b->head)
return BUFFER_EMPTY;

if (height < 1) {
zlog_warn(
"%s called with non-positive window height %d, forcing to 1",
__func__, height);
if (height < 1)
height = 1;
} else if (height >= 2)
else if (height >= 2)
height--;
if (width < 1) {
zlog_warn(
"%s called with non-positive window width %d, forcing to 1",
__func__, width);
if (width < 1)
width = 1;
}

/* For erase and more data add two to b's buffer_data count.*/
if (b->head->next == NULL) {
@@ -334,11 +327,6 @@ buffer_status_t buffer_flush_window(struct buffer *b, int fd, int width,
{
iov_alloc *= 2;
if (iov != small_iov) {
zlog_warn(
"%s: growing iov array to %d; "
"width %d, height %d, size %lu",
__func__, iov_alloc, width, height,
(unsigned long)b->size);
iov = XREALLOC(MTYPE_TMP, iov,
iov_alloc * sizeof(*iov));
} else {

0 comments on commit 07436e2

Please sign in to comment.
You can’t perform that action at this time.