|
| 1 | +2007-07-26 Paul Jakma <paul.jakma@sun.com> |
| 2 | + |
| 3 | + * (general) Clean up and compact capability parsing slightly. |
| 4 | + Consolidate validation of length and logging of generic TLV, and |
| 5 | + memcpy of capability data, thus removing such from cap specifc |
| 6 | + code (not always present or correct). |
| 7 | + * bgp_open.h: Add structures for the generic capability TLV header |
| 8 | + and for the data formats of the various specific capabilities we |
| 9 | + support. Hence remove the badly named, or else misdefined, struct |
| 10 | + capability. |
| 11 | + * bgp_open.c: (bgp_capability_vty_out) Use struct capability_mp_data. |
| 12 | + Do the length checks *before* memcpy()'ing based on that length |
| 13 | + (stored capability - should have been validated anyway on input, |
| 14 | + but..). |
| 15 | + (bgp_afi_safi_valid_indices) new function to validate (afi,safi) |
| 16 | + which is about to be used as index into arrays, consolidates |
| 17 | + several instances of same, at least one of which appeared to be |
| 18 | + incomplete.. |
| 19 | + (bgp_capability_mp) Much condensed. |
| 20 | + (bgp_capability_orf_entry) New, process one ORF entry |
| 21 | + (bgp_capability_orf) Condensed. Fixed to process all ORF entries. |
| 22 | + (bgp_capability_restart) Condensed, and fixed to use a |
| 23 | + cap-specific type, rather than abusing capability_mp. |
| 24 | + (struct message capcode_str) added to aid generic logging. |
| 25 | + (size_t cap_minsizes[]) added to aid generic validation of |
| 26 | + capability length field. |
| 27 | + (bgp_capability_parse) Generic logging and validation of TLV |
| 28 | + consolidated here. Code compacted as much as possible. |
| 29 | + * bgp_packet.c: (bgp_open_receive) Capability parsers now use |
| 30 | + streams, so no more need here to manually fudge the input stream |
| 31 | + getp. |
| 32 | + (bgp_capability_msg_parse) use struct capability_mp_data. Validate |
| 33 | + lengths /before/ memcpy. Use bgp_afi_safi_valid_indices. |
| 34 | + (bgp_capability_receive) Exported for use by test harness. |
| 35 | + * bgp_vty.c: (bgp_show_summary) fix conversion warning |
| 36 | + (bgp_show_peer) ditto |
| 37 | + * bgp_debug.h: Fix storage 'extern' after type 'const'. |
| 38 | + |
1 | 39 | 2007-07-31 Lorenzo Colitti <lorenzo@colitti.com> |
2 | 40 |
|
3 | 41 | * bgp_dump.c: (general) Add comments to code. |
|
0 commit comments