Skip to content
Permalink
Branch: master
Commits on Oct 9, 2019
  1. doc: update topotests doc for address sanitizer

    rzalamena committed Oct 9, 2019
    Use the `--enable-address-sanitizer` option instead of the manual
    version using environment flags.
    
    This also avoids the problem of having to remember to skip clippy with
    the custom flags:
    
    ```
    make -C lib CFLAGS="-g -O2" LDFLAGS="-g" clippy
    ```
    
    The snippet above is not needed with `--enable-address-sanitizer`!
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
  2. configure.ac: fix memory sanitizer test

    rzalamena committed Oct 8, 2019
    We should test for `-fsanitize=memory` instead of `-fsanitize=thread`
    when enabling memory sanitizer. While here, fix the error message.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Commits on Oct 1, 2019
  1. topotests: skip tests when any assert fails

    rzalamena committed Oct 1, 2019
    When an `assert` fails we should skip all other tests on the file. Once
    a failure is detected we can't rely on the setup anymore, since most of
    the tests assume the previous worked.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Commits on Sep 3, 2019
  1. Merge pull request #4922 from pguibert6WIND/bfd_close_sockets

    rzalamena committed Sep 3, 2019
    bfdd: close bfd echo sockets, upon vrf disable
Commits on Aug 3, 2019
  1. eigrpd: implement configuration reload

    rzalamena committed Aug 1, 2019
    Reload configuration on SIGHUP using the northbound.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
  2. eigrpd: migrate old CLI to northbound

    rzalamena committed Jul 30, 2019
    Move all configuration commands to the new CLI code (`eigrp_cli.c`),
    implement the northbound and do all the necessary wiring to get it
    working.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
  3. yang: change EIGRP authentication enum name

    rzalamena committed Aug 2, 2019
    In order to keep compatibility with the initial CLI, the enumeration
    name for sha2 was changed. No CLI code workarounds required.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Commits on Aug 1, 2019
  1. yang: simplify filter choice by removing cases

    rzalamena committed Aug 1, 2019
    Based on @rwestphal feedback, lets remove `case`s where we don't expect
    to add more items or items with more than one `leaf`.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
  2. yang: use filter types in route-map

    rzalamena committed Jul 25, 2019
    Import the new YANG model filter and use its types.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
  3. yang: initial filter YANG model import

    rzalamena committed Jul 5, 2019
    This model contains the description of access-list, prefix-list and
    other lists used by route map and other filtering interfaces.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
  4. yang: initial route-map YANG model import

    rzalamena committed Jul 2, 2019
    New model based on FRR's CLI and data structures.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Commits on Jul 30, 2019
  1. tools: generate code that handles all cases

    rzalamena committed Jul 29, 2019
    Help developers to start implementing northbound with more complete
    callbacks.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Commits on Jul 29, 2019
  1. tools: generate northbound code without warnings

    rzalamena committed Jul 29, 2019
    Use the alternate struct instantiation that does not generates warning
    on old compilers.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
  2. tools: allow YANG model path specification

    rzalamena committed Jul 29, 2019
    This allows developer to set a temporary YANG model directory path for
    generating northbound for models not yet installed.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Commits on Jul 26, 2019
  1. topotest: fix bgp-path-attributes-topology

    rzalamena committed Jul 26, 2019
    The first RIB check wants to assert that we don't have the r7's routes
    in r1, so right after that code the routers r2 and r3 are configured
    then `verify_rib` is called again to check for those routes.
    
    This test never passed, but it didn't cause failures because of the
    `try`/`except`.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Commits on Jul 23, 2019
  1. frr-reload.py: fix reload with different settings

    rzalamena committed Jul 17, 2019
    Add `allow-external-route-update` and `domainname` to the one line
    context list, otherwise reload will fail when those commands show up in
    the running configuration.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
  2. topotest: improve common_config.py

    rzalamena committed Jul 22, 2019
    Don't wait for `True` results when the return type is a string.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
  3. topotest: add new run_and_expect variant

    rzalamena committed Jul 22, 2019
    The new `run_and_expect` variant - called `run_and_expect_type` - tests
    the return value type of the test function and optionally the return
    value.
    
    Now we can implement tests from test functions that return different
    return types.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
  4. topotest: improve reliability of `verify_rib`

    rzalamena committed Jul 17, 2019
    Attempt to run the function multiple times to make sure we got the
    result we expected. This is a middle ground between big sleeps and short
    test intervals.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
  5. topotest/bgp_l3vpn_to_bgp_vrf: stabilize test

    rzalamena committed Jul 18, 2019
    Increase wait times between commands execution to help avoid bogus test
    failures.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
  6. topotest: adjust luCommand to accept wait_time

    rzalamena committed Jul 18, 2019
    Allow users of `luCommand` to specify wait time between commands
    execution and simplify the `wait` method implementation.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
  7. topotest: fix Lou's framework command wait

    rzalamena committed Jul 18, 2019
    Fix two main issues:
    
      * Don't use float to figure out if we spent the time user asked;
      * Don't depend on system clock to find we reached the end of time;
    
    The fix is basically pre caculating the amount of wait cycles we are
    going to peform and use a counter.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Commits on Jul 12, 2019
  1. isisd: improvements based on feedback

    rzalamena committed Jul 12, 2019
      * Remove sanity checks that are already done by northbound;
      * Show error message on circuit absence;
      * Use a better idiom for the configuration display code;
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Commits on Jul 9, 2019
  1. isisd: fix compilation warning on OpenBSD

    rzalamena committed Jul 9, 2019
    Use different declaration style to fix compilation warning on OpenBSD.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
  2. isisd: migrate BFD command to northbound

    rzalamena committed Jun 12, 2019
    Specify the ISIS BFD command in the YANG model and implement the
    northbound callbacks.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
  3. isisd: move old BFD command to fabricd only

    rzalamena committed Jun 12, 2019
    The `isisd` will receive a northbound version of the BFD command, so
    this is the first step to implement it.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
  4. yang/eigrp: change active-time timer to seconds

    rzalamena committed Jul 2, 2019
    Based on feedback.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
  5. bfdd: keep source information for single hop

    rzalamena committed Jul 8, 2019
    Add source address to northbound when creating sessions with this
    information. It is not possible to change source address after the
    session was created, but we should be able to set it to make IPv6 work.
    
    Spotted by Philippe Guibert.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
  6. yang: change single hop `leaf` order

    rzalamena committed Jul 8, 2019
    Move `source-address` to after the list keys, otherwise the CLI would
    get into an invalid state and be unable to set any other configuration
    inside that node.
    
    Spotted by Philippe Guibert.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Commits on Jul 2, 2019
  1. bfdd: fix some CI warnings

    rzalamena committed Jul 2, 2019
    Use `static` functions for file local functions to please `check_patch.pl`.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Commits on Jun 27, 2019
  1. yang: import EIGRP YANG model

    rzalamena committed Jun 20, 2019
    Based on Cisco YANG model but simplified to look more like FRR's CLI
    options and types.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Commits on Jun 25, 2019
  1. Merge pull request #4525 from donaldsharp/some_cleanups

    rzalamena committed Jun 25, 2019
    Some cleanups
  2. bfdd: convert `bfd` command to northbound

    rzalamena committed Jun 25, 2019
    This helps northbound to create the `bfd` node on the configuration
    output sooner than adding a peer.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
  3. bfdd: small tweaks on northbound

    rzalamena committed Jun 24, 2019
      * Change `ERR_VALIDATION` to `ERR_INCONSISTENCY` to error on
        inconsistent state.
      * Duplicated sanity checks:
        * Remove detection multiplier sanity check.
        * Remove duplicated session sanity check.
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Commits on Jun 24, 2019
  1. bfdd: fix compilation warnings on OmniOS

    rzalamena committed Jun 24, 2019
    Build will fail with `Werror` enabled with:
    
    ```
      CC       bfdd/bfdd_cli.o
    In file included from ./lib/frratomic.h:21:0,
                     from ./lib/memory.h:22,
                     from ./lib/vector.h:25,
                     from ./lib/command.h:25,
                     from bfdd/bfdd_cli.c:23:
    ./config.h:665:0: error: "_FILE_OFFSET_BITS" redefined [-Werror]
     #define _FILE_OFFSET_BITS 64
     ^
    In file included from /usr/include/iso/stdlib_iso.h:49:0,
                     from /usr/include/stdlib.h:37,
                     from ./lib/memory.h:20,
                     from ./lib/vector.h:25,
                     from ./lib/command.h:25,
                     from bfdd/bfdd_cli.c:23:
    /opt/gcc-5.1.0/lib/gcc/i386-pc-solaris2.11/5.1.0/include-fixed/sys/feature_tests.h:231:0: note: this is the location of the previous definition
     #define _FILE_OFFSET_BITS 32
     ^
    In file included from ./lib/thread.h:24:0,
                     from ./lib/vty.h:27,
                     from ./lib/command.h:26,
                     from bfdd/bfdd_cli.c:23:
    ./lib/zebra.h:271:2: error: #warning "assuming 4-byte alignment for CMSG_SPACE" [-Werror=cpp]
     #warning "assuming 4-byte alignment for CMSG_SPACE"
      ^
    ./lib/zebra.h:277:2: error: #warning "assuming 4-byte alignment for CMSG_LEN" [-Werror=cpp]
     #warning "assuming 4-byte alignment for CMSG_LEN"
      ^
    cc1: all warnings being treated as errors
    Makefile:6876: recipe for target 'bfdd/bfdd_cli.o' failed
    gmake[1]: *** [bfdd/bfdd_cli.o] Error 1
    ```
    
    Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Older
You can’t perform that action at this time.