New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BGP Large Communities #46

Closed
job opened this Issue Jan 5, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@job
Contributor

job commented Jan 5, 2017

@donaldsharp

This comment has been minimized.

Show comment
Hide comment
@donaldsharp

donaldsharp Jan 18, 2017

Member

@job I submitted #86. Before we can go further since you are the author of the patch we need approval to place a 'Signed-off-by: ...' from you and I would love to have a better commit message. Do you have something to suggest?

Member

donaldsharp commented Jan 18, 2017

@job I submitted #86. Before we can go further since you are the author of the patch we need approval to place a 'Signed-off-by: ...' from you and I would love to have a better commit message. Do you have something to suggest?

@job

This comment has been minimized.

Show comment
Hide comment
@job

job Jan 18, 2017

Contributor

Yes, looks good, feel free to add Signed-off-by: Job Snijders <job@ntt.net>

Commit message:

Support for BGP Large Communities

BGP Large Communities are a novel way to signal information between
networks. An example of a Large Community is: "2914:65400:38016". Large
BGP Communities are composed of three 4-byte integers, separated by a
colon. This is easy to remember and accommodates advanced routing
policies in relation to 4-Byte ASNs.

This feature was developed by Keyur Patel <keyur@arrcus.com> (Arrcus, Inc.),
Job Snijders <job@ntt.net> (NTT Communications), and Donald Sharp.

General information: http://largebgpcommunities.net/
IETF Internet-Draft: https://tools.ietf.org/html/draft-ietf-idr-large-community
Contributor

job commented Jan 18, 2017

Yes, looks good, feel free to add Signed-off-by: Job Snijders <job@ntt.net>

Commit message:

Support for BGP Large Communities

BGP Large Communities are a novel way to signal information between
networks. An example of a Large Community is: "2914:65400:38016". Large
BGP Communities are composed of three 4-byte integers, separated by a
colon. This is easy to remember and accommodates advanced routing
policies in relation to 4-Byte ASNs.

This feature was developed by Keyur Patel <keyur@arrcus.com> (Arrcus, Inc.),
Job Snijders <job@ntt.net> (NTT Communications), and Donald Sharp.

General information: http://largebgpcommunities.net/
IETF Internet-Draft: https://tools.ietf.org/html/draft-ietf-idr-large-community
@donaldsharp

This comment has been minimized.

Show comment
Hide comment
@donaldsharp

donaldsharp Jan 18, 2017

Member

@job I will initiate a new Pull Request with this commit message.

Member

donaldsharp commented Jan 18, 2017

@job I will initiate a new Pull Request with this commit message.

@eqvinox

This comment has been minimized.

Show comment
Hide comment
@eqvinox

eqvinox Jan 25, 2017

Contributor

#92 merged, large community support now in master.

Contributor

eqvinox commented Jan 25, 2017

#92 merged, large community support now in master.

@eqvinox eqvinox closed this Jan 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment