Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compilation fails on 1-core VM #6576

Closed
bmwiedemann opened this issue Jun 13, 2020 · 1 comment · Fixed by #6615
Closed

compilation fails on 1-core VM #6576

bmwiedemann opened this issue Jun 13, 2020 · 1 comment · Fixed by #6615
Assignees
Labels
triage Needs further investigation

Comments

@bmwiedemann
Copy link

Describe the bug
When building the frr-7.3.1 as packaged in our openSUSE Linux distribution, the build fails on 1-core VMs but succeeds on 4-core VMs. This is indicative of insuffiently specified build dependencies.

[x] Did you check if this is a duplicate issue?
[x] Did you test it on the latest FRRouting/frr master branch?

To Reproduce
Steps to reproduce the behavior (on openSUSE or Debian):

  1. osc checkout openSUSE:Factory/frr && cd $_
  2. osc build --vm-type=kvm -j1 --noservice
  3. See error

Expected behavior
Build should not fail

Screenshots
Build log has

 gcc -std=gnu11 -DHAVE_CONFIG_H -DSYSCONFDIR=\"/etc/frr/\" -DCONFDATE=0 -I.  -I. -I./include -I./lib -I. -I./include -I./lib          -ffat-lto-objects -fno-omit-frame-pointer -funwind-tables -Wall -Wextra -Wmissing-prototypes -Wmissing-declarations -Wpointer-arith -Wbad-function-cast -Wwrite-strings -Wno-unused-result -Wno-unused-parameter -Wno-missing-field-initializers -pthread -c -o zebra/zebra_mlag.o zebra/zebra_mlag.c
 In file included from zebra/zebra_mlag.c:29:
 ./zebra/zebra_mlag.h:30:10: fatal error: mlag/mlag.pb-c.h: No such file or directory
    30 | #include "mlag/mlag.pb-c.h"
       |          ^~~~~~~~~~~~~~~~~~
 compilation terminated.
 make[1]: *** [Makefile:7578: zebra/zebra_mlag.o] Error 1 
 make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/frr-frr-7.3.1'
 make: *** [Makefile:4506: all] Error 2 

Versions

  • FRR Version 7.3.1 and master

Additional context
This issue was found as part of my work on reproducible builds for openSUSE.

@bmwiedemann bmwiedemann added the triage Needs further investigation label Jun 13, 2020
@eqvinox eqvinox self-assigned this Jun 16, 2020
eqvinox added a commit to opensourcerouting/frr that referenced this issue Jun 18, 2020
Need to list #include'd header files in Makefile to make sure it builds
correctly.

Fixes: FRRouting#6576
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
@bmwiedemann
Copy link
Author

I locally cherry-picked 4b7272c onto stable/7.3 and verified that it fixed this issue.

Many thanks @donaldsharp !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs further investigation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants