Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix several Alpine build issues related to ELF parsing #8491

Merged
merged 2 commits into from Apr 18, 2021
Merged

Fix several Alpine build issues related to ELF parsing #8491

merged 2 commits into from Apr 18, 2021

Conversation

qlyoung
Copy link
Member

@qlyoung qlyoung commented Apr 15, 2021

Several issues:

  1. libelf-dev dependency was not added to APKBUILD.in for Alpine packaging
  2. Our Alpine base image was using the latest tag, which is unstable and not appropriate for us
  3. Once libelf-dev is added, our FRR Alpine images no longer build because libelf-dev hasn't been available in Alpine since 3.9; work around this by adding 3.9 Alpine repository to the 3.13 base image before building FRR

Fixes: #8489

@qlyoung qlyoung requested review from eqvinox and wesl-ee April 15, 2021 22:19
@LabN-CI
Copy link
Collaborator

LabN-CI commented Apr 16, 2021 •
edited

Outdated results 💚

Basic BGPD CI results: SUCCESS, 0 tests failed

_ _
Result SUCCESS git merge/8491 3df81c2
Date 04/15/2021
Start 19:57:12
Finish 20:38:29
Run-Time 41:17
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2021-04-15-19:57:12.txt
Log autoscript-2021-04-15-19:58:21.log.bz2
Memory 496 488 431

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Apr 16, 2021 •
edited

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18434/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@wesl-ee
Copy link
Contributor

wesl-ee commented Apr 16, 2021 •
edited

I don't think this is related to this change (I mean, Alpine was broken before so this is a needed fix) but I get this on starting a built container now:

w@kvm-gentoo ~/code/frr $ ./docker/alpine/build.sh
[...]
w@kvm-gentoo ~/code/frr $ docker run -it frr:alpine-3df81c2e10
cannot run start: /etc/frr/daemons does not exist

I can go in and inspect the container and see that /etc/frr is a regular file, not a directory.

w@kvm-gentoo ~/code/frr $ docker run --entrypoint /bin/bash -it frr:alpine-3df81c2e10
bash-5.1# ls /etc -l |grep frr
-rw-r--r--    1 root     root          2619 Apr 16 02:10 frr

The file is just an /etc/frr/daemons file

bash-5.1# cat /etc/frr 
# This file tells the frr package which daemons to start.
#
# Sample configurations for these daemons can be found in
# /usr/share/doc/frr/examples/.
[...]

Just curious if you can build & run or if my docker is playing tricks with me.

@eqvinox
Copy link
Contributor

eqvinox commented Apr 16, 2021 

3. Once `libelf-dev` is added, our FRR Alpine images no longer build because `libelf-dev` hasn't been available in Alpine since 3.9; work around this by adding 3.9 Alpine repository to the 3.13 base image before building FRR

The correct package seems to be elfutils-dev (https://git.alpinelinux.org/aports/tree/main/elfutils/APKBUILD?h=3.13-stable)

@qlyoung
Copy link
Member Author

qlyoung commented Apr 16, 2021

Right you are...couldn't find that anywhere

@qlyoung
alpine: add missing libelf-dev dependency
daff938 
Signed-off-by: Quentin Young <qlyoung@nvidia.com>
@qlyoung
docker: pin alpine base image to 3.13
9513086 
'latest' isn't appropriate for us

Signed-off-by: Quentin Young <qlyoung@nvidia.com>
@qlyoung qlyoung force-pushed the fix-alpine-libelf-dev-build branch from 3df81c2 to 9513086 Compare April 16, 2021 17:02
@LabN-CI
Copy link
Collaborator

LabN-CI commented Apr 16, 2021

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/8491 9513086
Date 04/16/2021
Start 13:05:44
Finish 13:46:52
Run-Time 41:08
Total 1815
Pass 1815
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2021-04-16-13:05:44.txt
Log autoscript-2021-04-16-13:06:50.log.bz2
Memory 505 484 429

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

NetDEF-CI commented Apr 16, 2021 •
edited

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18441/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 1: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 1: No useful log found
Successful on other platforms/tests
  • Addresssanitizer topotests part 7
  • Topotests Ubuntu 18.04 arm8 part 9
  • Topotests Ubuntu 18.04 arm8 part 4
  • Static analyzer (clang)
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests Ubuntu 16.04 i386 part 2
  • Fedora 29 rpm pkg check
  • Topotests Ubuntu 18.04 arm8 part 5
  • Topotests Ubuntu 18.04 arm8 part 0
  • Addresssanitizer topotests part 0
  • Addresssanitizer topotests part 4
  • Topotests Ubuntu 18.04 amd64 part 4
  • Ubuntu 18.04 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 1
  • Topotests Ubuntu 16.04 i386 part 5
  • Topotests Ubuntu 16.04 i386 part 7
  • CentOS 7 rpm pkg check
  • Topotests Ubuntu 18.04 amd64 part 2
  • IPv6 protocols on Ubuntu 18.04
  • Topotests Ubuntu 18.04 amd64 part 0
  • Topotests Ubuntu 18.04 arm8 part 3
  • Topotests Ubuntu 18.04 amd64 part 3
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 arm8 part 8
  • Topotests Ubuntu 18.04 arm8 part 6
  • IPv4 protocols on Ubuntu 18.04
  • Topotests Ubuntu 16.04 i386 part 0
  • Addresssanitizer topotests part 8
  • Debian 10 deb pkg check
  • Topotests Ubuntu 16.04 i386 part 9
  • Topotests Ubuntu 16.04 i386 part 1
  • Topotests Ubuntu 16.04 i386 part 8
  • Ubuntu 16.04 deb pkg check
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 amd64 part 6
  • Topotests Ubuntu 18.04 amd64 part 5
  • IPv4 ldp protocol on Ubuntu 18.04
  • Addresssanitizer topotests part 2
  • Ubuntu 20.04 deb pkg check
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 16.04 i386 part 3
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests Ubuntu 18.04 arm8 part 2
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 16.04 i386 part 4
  • Topotests Ubuntu 16.04 i386 part 6

@qlyoung
Copy link
Member Author

qlyoung commented Apr 17, 2021

ci:rerun

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-18453/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

@eqvinox
Copy link
Contributor

eqvinox commented Apr 18, 2021

Merging, since it was b0rked before this can't make it worse ;)

@eqvinox eqvinox merged commit 79ec61b into FRRouting:master Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eqvinox eqvinox eqvinox approved these changes

@wesl-ee wesl-ee Awaiting requested review from wesl-ee

Assignees
No one assigned
Labels
docker packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alpine builds broken due to missing libelf-dev dependency
6 participants
@qlyoung @LabN-CI @NetDEF-CI @wesl-ee @eqvinox @polychaeta